Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: General UI Readability Improvements #339

Closed
3 tasks
hk21702 opened this issue May 16, 2024 · 0 comments · Fixed by #341
Closed
3 tasks

Suggestion: General UI Readability Improvements #339

hk21702 opened this issue May 16, 2024 · 0 comments · Fixed by #341
Labels
accessibility 👀 ℹ️🤓 user-friendly optimization, like notifications, warnings and action alerts

Comments

@hk21702
Copy link
Collaborator

hk21702 commented May 16, 2024

Is your feature request related to a problem? Please describe.
There are some significant shortcomings in terms of readability in certain parts of the app that manifest at least in windows (and I presume in other os's since it relates to the pyside stylesheet mostly).

  • 1. Radio button text is currently dark on dark. (No styling exists for radio buttons currently)
  • 2. Some items such as buttons have padding issues where the text is very close to the left and right edges (There's only 1px of padding around buttons. It really should be more. As an example, material design common buttons have left right padding of 24px, though even a padding of just 5px would be better.)
  • 3. The menu bar of the app in terms of styling is rather inconsistent with the rest of the app on windows. I don't think any styling exists for it. My understanding is that it defaults to system default for mac/linux, but not on windows which is rather ugly without styling.

Describe the solution you'd like
I'm willing to help make these changes in a pull request, I'm just opening this issue first for purposes of discussion.

@hk21702 hk21702 mentioned this issue May 16, 2024
@hk21702 hk21702 linked a pull request May 17, 2024 that will close this issue
@hk21702 hk21702 added the accessibility 👀 ℹ️🤓 user-friendly optimization, like notifications, warnings and action alerts label May 17, 2024
hk21702 added a commit that referenced this issue May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 👀 ℹ️🤓 user-friendly optimization, like notifications, warnings and action alerts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant