This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Don't use temporary buffers when parsing PID maps in pmparser #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FORTIFY_SOURCE is upset that the source buffer sizes for the strcpys in pmparser_parse() are larger than the destination buffers. Using the destination buffer directly fixes runtime crashes like these: 03-24 10:53:16.802 2758 2758 F libc : FORTIFY: strcpy: prevented 8-byte write into 5-byte buffer 03-24 10:53:16.802 2758 2758 F libc : Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 2758 (main), pid 2758 (main)
yujincheng08
approved these changes
Mar 24, 2021
RikkaW
added a commit
to RikkaApps/Shizuku
that referenced
this pull request
Mar 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FORTIFY_SOURCE is upset that the source buffer sizes for the strcpys in
pmparser_parse() are larger than the destination buffers. Using the
destination buffer directly fixes runtime crashes like these:
03-24 10:53:16.802 2758 2758 F libc : FORTIFY: strcpy: prevented 8-byte write into 5-byte buffer
03-24 10:53:16.802 2758 2758 F libc : Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 2758 (main), pid 2758 (main)