Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notes for releasing new versions #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

damien868
Copy link

There are no notes on how to release a new version of this package in the event that we need to upgrade this package and publish the new version on the npm registry. This PR adds notes on how to accomplish this.

@damien868 damien868 requested a review from a team July 10, 2024 17:40
@damien868 damien868 self-assigned this Jul 10, 2024
2. Change the version number to a new unused version in `package.json` and `package-lock.json`.
3. Ensure the angular cli is installed by running `npm install -g @angular/cli`.
4. Run `npm run build:lib`
5. cd into projects/ng2-smart-table

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we cd into the dist folder that was generated by the build command?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I believe we ended up cd'ing out of it. I will actually need to do this a few more times to correctly upgrade angular. Let's put this PR on hold for now and I can update the directions fully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants