Support $ref in requestBody
#4917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eatdrinksleepcode
force-pushed
the
actual-request-body
branch
2 times, most recently
from
64474b1
to
1018295
Compare
eatdrinksleepcode
force-pushed
the
actual-request-body
branch
from
1018295
to
905d526
Compare
eatdrinksleepcode
force-pushed
the
actual-request-body
branch
from
905d526
to
03897bb
Compare
|
Thanks for the PR. |
|
Hey guys. This is the support for external files I guess. What about request requestBodies in the same file. I still have an exception. Example: The .yaml snippet looks like this It's not generating the request object at all. When i change the requestBody to this: Then the reference can not be found. |
|
This is not part of nswag v14.1.0… part of next release |
|
Thank you Rico :-) |
|
I thought my pull request #4747 was now unneeded. But this change does not what I expect. With this I still get I updated my pull request to add the missing code. Is that the cross update you mentioned? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2122
This MR adds support for
$refinrequestBody, as well asrequestBodiesincomponents.Since the existing implementation does not attempt to do cross-updates between
OpenApiRequestBodyand a referencedOpenApiParameter, so this MR does not attempt to cross-update the other direction.