Do not set clientSecret for CODE-PKCE #4184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicoSuter
added a commit
that referenced
this pull request
Jan 17, 2024
|
I need to revert this PR as it breaks our application. |
|
Ok, no problem. I am curious, how it can break the application |
|
In our case we need the secret and usePkceWithAuthorizationCodeGrant = true, dont ask me why... |
|
Got it, thanks :) |
lahma
pushed a commit
to lahma/NSwag
that referenced
this pull request
Jan 20, 2024
lahma
pushed a commit
to lahma/NSwag
that referenced
this pull request
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, my oauth server is complaining that I send
client_secretwhen using code flow with PKCE. This PR should resolve the issue