Merge pull request #15 from KarlosQ/master

Use project-wide properties in sample
Richou · Jul 20, 2018 · 53ac46e · 53ac46e
2 parents d62ca0d + 46e7dd8
commit 53ac46e
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/android/build.gradle b/android/build.gradle
@@ -1,3 +1,7 @@
+def safeExtGet(prop, fallback) {
+    rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
+}
+
 buildscript {
     repositories {
         mavenCentral()
@@ -13,12 +17,12 @@ buildscript {
 apply plugin: 'com.android.library'
 
 android {
-    compileSdkVersion 27
-    buildToolsVersion "27.0.3"
+        compileSdkVersion safeExtGet('compileSdkVersion', 27)
+        buildToolsVersion safeExtGet('buildToolsVersion', '27.0.3')
 
-    defaultConfig {
-        minSdkVersion 16
-        targetSdkVersion 27
+  defaultConfig {
+        minSdkVersion safeExtGet('minSdkVersion', 16)
+        targetSdkVersion safeExtGet('targetSdkVersion', 27)
         versionCode 3
         versionName "1.2"
         ndk {
@@ -30,8 +34,10 @@ android {
     }
 }
 
+
 dependencies {
     api fileTree(include: ['*.jar'], dir: 'libs')
     api 'com.facebook.react:react-native:+'
-    api 'com.google.android.gms:play-services-location:15.0.1'
+    api "com.google.android.gms:play-services-location:${safeExtGet('googlePlayServicesVersion', '15.0.1')}"
 }
+
diff --git a/samples/LocationEnable/android/build.gradle b/samples/LocationEnable/android/build.gradle
@@ -24,3 +24,11 @@ allprojects {
         google()
     }
 }
+ext {
+    buildToolsVersion = "27.0.3"
+    minSdkVersion = 16
+    compileSdkVersion = 27
+    targetSdkVersion = 27
+    supportLibVersion = "27.1.1"
+    googlePlayServicesVersion = "15.0.1"
+}