-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a list of rules from the spec #4
Comments
Here’s some more ideas. The checked ones are in GH-6 and GH-8. List of rules
List of external rules that may be useful
List of random ideas for rules
|
Finally, as a start to validate the schema / heading outline, I created the following list from the spec: Schema
|
That looks right to me! Maintainer is optional, now. This should be relatively easy to check - for instance, the banner, badges, short and long description could be ignored in a heading check. Check the beginning to match, and the last two, and then note if any of the ones present are mistakenly put in the extra sections bit. |
Yeah I was thinking about how to check the heading-less stuff too. I came up with the idea of a utility that transforms the AST into a schema (an object form of the above), which you can then check for validity (or use for other tools!) |
The headingless-stuff should only really be in the main section before any second level headers (which would be TOC, background, security, or install). So, that should be in a separate check. That makes checking the titles easier, right? |
True, yeah definitely! I was thinking more about how to do it perfectly, how it’s supposed to be, than how to do it quickly/for now! |
Modified the above schema to make Maintainers optional. |
* `no-unknown-sections`: checks that unknown sections are placed in the extra sections * `require-sections`: checks that required sections are used * `section-order`: checks that sections are used in the prescribed outline order Related to GH-4.
#4 (comment) updated for GH-8. |
Initially, you can make them as packages in this folder, and then require them in
index.js
file as needed. When they are suitably abstracted, put them into their own packages.The text was updated successfully, but these errors were encountered: