convert to JS #38
convert to JS #38
Conversation
|
"Buble", wow, that's a blast from the past. |
|
yeah, still the easiest way to turn |
|
|
||
| const VERSION = "__VERSION__"; | ||
|
|
||
| export { transform, define, load, VERSION }; |
There was a problem hiding this comment.
[comment]
would be nice to see this diff as a git mv, but minimal changes so it looks fine
| * @param {(__import: __Import, __exports: __Exports, ...deps: any[]) => void} factory | ||
| */ | ||
| export function define(id, deps, factory) { | ||
| const __import = (dep) => load(new URL(dep, id).toString()); |
There was a problem hiding this comment.
[comment]
just making a note that toString was added, but it looks like the typescript version expected a string | URL but then just cast to string, so expected functionality should be the same
| // for browsers without `URL` | ||
| return <unknown>(0,eval)(code); | ||
| } | ||
| } |
There was a problem hiding this comment.
[comment]
same here, diff would be happier as a git mv
|
|
||
| function tokenClosesExpression() { | ||
| if (lsc() === ')') { | ||
| var c = parenMatches[lsci]; | ||
| let c = parenMatches[lsci]; |
There was a problem hiding this comment.
[comment]
noting functional change, var -> let, yay scope
| if (a.name === 'default') return 1; | ||
| if (b.name === 'default') return -1; | ||
| }) | ||
| .forEach((s: Specifier) => { | ||
| .forEach((s) => { |
There was a problem hiding this comment.
[comment]
lost some types in these sort/forEach methods, doesn't seem like a big deal
| @@ -658,7 +766,7 @@ export function transform(source: string, id: string) { | |||
|
|
|||
| let transformed = `__shimport__.define('${id}', [${deps}], function(${names}){ ${hoisted.join('')}`; | |||
|
|
|||
| const ranges: any[] = [ | |||
| const ranges = [ | |||
There was a problem hiding this comment.
[comment]
lost a type here, any[] can probably just get inferred since it's initialized as an array but it might still be worth keeping?
|
bump |
No description provided.