Fixed bug in is_team_home, failed if team doesn't have playoffs

RiccardoBarbieri · Jul 16, 2024 · bab29c6 · bab29c6
1 parent 788e97f
commit bab29c6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/nba_api/deployment/version b/nba_api/deployment/version
@@ -1 +1 @@
-1.2.0
+1.2.1
diff --git a/nba_api/featurevec/feature_vector_calculator.py b/nba_api/featurevec/feature_vector_calculator.py
@@ -299,7 +299,9 @@ def is_team_home(team_ticker: str, game_id: str, season: str) -> bool:
     :return: A boolean representing if the team is the home team.
     """
     team_game_log = get_season_games_for_team(team_ticker, season, False)
-    team_game_log.extend(get_season_games_for_team(team_ticker, season, True))
+    if playoffs := get_season_games_for_team(team_ticker, season, True):
+        team_game_log.extend(playoffs)
+
     for game in team_game_log:
         if game['game_id'] == game_id:
             return get_home_away_team(game['matchup'])['home_team'] == team_ticker