Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ribir_core should not depends ribir_gpu and winit #233

Open
M-Adoo opened this issue Feb 12, 2023 · 1 comment
Open

ribir_core should not depends ribir_gpu and winit #233

M-Adoo opened this issue Feb 12, 2023 · 1 comment

Comments

@M-Adoo
Copy link
Collaborator

M-Adoo commented Feb 12, 2023

No description provided.

@M-Adoo M-Adoo added this to the 0.1 milestone Feb 27, 2023
zoechi added a commit to zoechi/Ribir that referenced this issue Mar 6, 2023
@zoechi
DRAFT: Remove ribir_gpu and winit dependencies from ribir_core
5475530 
fixes RibirX#233
Move the dependencies to a new create `ribir_app_winit`
and create abstractions to break up dependencies in ribir_core code.
@zoechi zoechi mentioned this issue Mar 6, 2023
Closed
@zoechi
Copy link
Contributor

zoechi commented Mar 9, 2023

I thought if I mention the issue in a Discussions comment a link will show up here.
Because it didn't I add this here:
there is additional discussion about this issue in #266 and #273

@zoechi zoechi mentioned this issue Mar 15, 2023
Closed
@M-Adoo M-Adoo removed this from the 0.1 milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zoechi @M-Adoo