feat: add VES currency #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sk-
reviewed
Nov 14, 2023
currency.go
Outdated
| @@ -203,6 +203,7 @@ var currencies = Currencies{ | |||
| UYU: {Decimal: ".", Thousand: ",", Code: UYU, Fraction: 2, NumericCode: "858", Grapheme: "$U", Template: "$1"}, | |||
| UZS: {Decimal: ".", Thousand: ",", Code: UZS, Fraction: 2, NumericCode: "860", Grapheme: "so\u2019m", Template: "$1"}, | |||
| VEF: {Decimal: ".", Thousand: ",", Code: VEF, Fraction: 2, NumericCode: "928", Grapheme: "Bs", Template: "$1"}, | |||
There was a problem hiding this comment.
Note this currency has the wrong numeric code, which would make it fail in case the function CurrencyByNumericCode is used, because it has the same value as the newly added VES currency.
Line 21 in 11fb01e
The correct value for VEF is 937 according to https://www.six-group.com/dam/download/financial-information/data-center/iso-currrency/lists/list-three.xml (https://www.six-group.com/en/products-services/financial-information/data-standards.html)
There was a problem hiding this comment.
Thanks! I'm changing that on the PR.
|
Thanks for contribution! Going to create new release in a bit |
Rhymond
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #138