Revert #65 #69
Merged
Revert #65 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwsean08
changed the title
|
This isn't quite working yet, I've regressed to where it's not honoring the sensitive_post_parameters I've realized after a bit more testing |
wwsean08
changed the title
|
Reverting #65 because I don't think I have a good way of solving both issues, I'll investigate this another time but for now a revert seems like a better choice. |
|
That works. I'm guessing you could simply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the RawPostDataException reported in #67 caused by #65. This does come at the expense of a bit more memory usage because we store off the body. I tested against the thest case provided by @therefromhere and am no longer getting the error (though I am getting a stacktrace because of a missing template).