Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Darwinia and Crab network #195

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Add Darwinia and Crab network #195

merged 6 commits into from
Feb 29, 2024

Conversation

nblogist
Copy link
Contributor

Hi @rkalis thank you helping maintain this important app, and for taking the time to review this, just added the two networks! lmk if you'd like any changes :)

nblogist and others added 3 commits February 19, 2024 18:32

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
added crab and darwinia networks
Copy link

vercel bot commented Feb 21, 2024

@nblogist is attempting to deploy a commit to the Kalis Software Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
revoke-cash ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 7:38pm

Copy link
Member

@rkalis rkalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nblogist, thanks for the PR. It looks like the Darwinia / Crab RPCs aren't performing well enough for it to work reliably (this is often the case for many networks due to our intensive RPC requests). I see that they do have Blockscout-based block explorers though (https://crab.subview.xyz/ and https://darwinia.subview.xyz/), so it looks like it could be possible to add them as blockscout-supported chains instead.

CleanShot 2024-02-22 at 09 47 30@2x

@nblogist
Copy link
Contributor Author

Thank you for taking the time to review and provide feedback and a solution @rkalis , Just pushed a commit :)

@nblogist nblogist requested a review from rkalis February 23, 2024 20:28
@rkalis
Copy link
Member

rkalis commented Feb 26, 2024

Looks like https://crab.subview.xyz/ is giving a 502 Bad Gateway error right now. Let's wait for some days to see if it resolves itself.

@hackfisher
Copy link

Looks like https://crab.subview.xyz/ is giving a 502 Bad Gateway error right now. Let's wait for some days to see if it resolves itself.

Hi, just notified the service provider of crab.subview.xyz, they are syncing a new rpc node to make it more reliable. It should be ok after some days.

@rkalis
Copy link
Member

rkalis commented Feb 28, 2024

Hey @nblogist, I tried to push some changes to this PR, but I'm getting a permission denied. Could you make sure to check "Allow edits from maintainers"?

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@nblogist
Copy link
Contributor Author

Hey @rkalis I had already turned it on :)
image

@rkalis
Copy link
Member

rkalis commented Feb 29, 2024

Thanks @nblogist, looks like I probably was doing something wrong with git on my side.

@rkalis rkalis changed the title Adding Darwinia and Crab network Add Darwinia and Crab network Feb 29, 2024
@rkalis rkalis merged commit 3eb0256 into RevokeCash:master Feb 29, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants