Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use #fileID instead of #file to avoid including the full path in the compiled binary #4605

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Use #fileID instead of #file to avoid including the full path in the compiled binary #4605

merged 1 commit into from
Dec 17, 2024

Conversation

MarkVillacampa
Copy link
Member

These were the only non-test files where we were using #file instead of #fileID

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-android and hybrids

Motivation

Description

fire-at-will
fire-at-will approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@fire-at-will fire-at-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

JayShortway
JayShortway approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@JayShortway JayShortway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@MarkVillacampa MarkVillacampa merged commit 9260189 into main Dec 17, 2024
10 checks passed
@MarkVillacampa MarkVillacampa deleted the fileid branch December 17, 2024 17:42
@MarkVillacampa MarkVillacampa changed the title Use #file instead of #fileID to avoid including the full path in the compiled binary Use #fileID instead of #file to avoid including the full path in the compiled binary Dec 17, 2024
@RCGitBot RCGitBot mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayShortway JayShortway JayShortway approved these changes

@fire-at-will fire-at-will fire-at-will approved these changes

Assignees
No one assigned
Labels
pr:other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkVillacampa @fire-at-will @JayShortway