Fix translucent navigation bar on paywalls by making it fully transparent (on iOS 16+) #4543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent (on iOS 16+)
joshdholtz
force-pushed
the
mon-624-paywalls-rendering-with-a-unwanted-toolbar-using-uikit
branch
from
907ddf0 to
d6215ae
Compare
MarkVillacampa
approved these changes
Dec 5, 2024
aboedo
approved these changes
Dec 5, 2024
joshdholtz
deleted the
mon-624-paywalls-rendering-with-a-unwanted-toolbar-using-uikit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There was a translucent navigation bar on some of the paywall templates when scrolling. We don't want that.
Description
.toolbarBackground(.hidden, for: .navigationBar)(if available)Before
Screen.Recording.2024-12-05.at.10.02.08.AM.mov
After
Screen.Recording.2024-12-05.at.10.01.23.AM.mov