Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up API Testers #4141

Merged
merged 24 commits into from
Aug 5, 2024
Merged

Clean up API Testers #4141

merged 24 commits into from
Aug 5, 2024

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Jul 31, 2024

API Testers cleanup

  • Moves all API Testers into main RevenueCat workspace
  • ensure that they all use the local build, not a hardcoded commit
  • kill all the separate projects, create a single project with a framework per test (objc api tests, swift api tests, etc, etc)
  • creates a single scheme that builds all of those targets in one pass
  • update relevant CI (to do)

Here's what this actually looks like: a single scheme in Xcode, which you can test using command + U (or just build, since it effectively works too)

Screenshot 2024-07-31 at 6 09 33 PM Screenshot 2024-07-31 at 6 09 44 PM

Note:
Okay, I'd directly recommend not reviewing the diff, since it's kind of insane, and instead checking out the branch to see if things make sense.

aboedo added 14 commits July 31, 2024 17:25
@aboedo
added all api tests to the xcode project, created a new framework tar…
7d3a6e8 
…get to replace the old objc api tester
@aboedo
remove old objc api tester
67b1527
@aboedo
replace old swift api tester with framework
4b7bcc3
@aboedo
remove old swift api tester references
ae812aa
@aboedo
more clean up
1b9ccd4
@aboedo
replade old receipt parser api tester with new one
8233805
@aboedo
clean up old receipt parser API tester
b697f73
@aboedo
replace old RevenueCatUI Swift API Tester with new one as framework
faf25d0
@aboedo
clean up old RevenueCat UI Swift API Tester references
375d399
@aboedo
remove old custom entitlements computation api tester project, replac…
c28cf86 
…ed with new framework
@aboedo
clean up old references
a1a213e
@aboedo
clean up some test targets
1e9b43c
@aboedo
clean up all remaining test targets
ce81479
@aboedo
fix availability checks in custom entitlements computation swift API …
36826e4 
…tests
@aboedo aboedo added the ci label Jul 31, 2024
@aboedo aboedo self-assigned this Jul 31, 2024
@RevenueCat-Danger-Bot
Copy link

RevenueCat-Danger-Bot commented Jul 31, 2024 •
edited
Loading

1 Warning
⚠️ This PR increases the size of the repo by more than 100.00 KB (increased by 110.68 KB).

Generated by 🚫 Danger

@aboedo
Copy link
Member Author

aboedo commented Jul 31, 2024

Note: I haven't fixed the tests yet, so if we ask gitbot to test this it's going to go a bit nuts

@aboedo
Copy link
Member Author

aboedo commented Jul 31, 2024

@RCGitBot please test

@aboedo
Copy link
Member Author

aboedo commented Jul 31, 2024

I'm particularly curious about the carthage installation tests, since those are the ones that do look at all the schemes, so that's where the bigger change would be

@aboedo aboedo marked this pull request as ready for review July 31, 2024 21:22
@aboedo
Copy link
Member Author

aboedo commented Jul 31, 2024

haha called it, carthage failed. I'll mark this as draft again while I figure that out

@aboedo aboedo marked this pull request as draft July 31, 2024 21:28
@aboedo
Copy link
Member Author

aboedo commented Aug 2, 2024

@RCGitBot please test

@aboedo
Copy link
Member Author

aboedo commented Aug 2, 2024

Carthage installation tests also thankfully raised a number of places where we weren't doing platform checks correctly in CustomEntitlementsComputationAPITests and a couple of other places, and also they made me notice a bunch of places where the deployment targets weren't correctly set, so I also cleaned that up

@aboedo aboedo marked this pull request as ready for review August 2, 2024 20:38
@aboedo aboedo requested a review from a team August 2, 2024 20:38
tonidero
tonidero approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Had to update Xcode since the target for the tests is iOS 17.5, but that should be ok :)

@aboedo
Copy link
Member Author

aboedo commented Aug 5, 2024

@tonidero good looking out, I hadn't noticed that. I'll update the tests's deployment targets in a follow up

@aboedo aboedo merged commit facc690 into main Aug 5, 2024
33 checks passed
@aboedo aboedo deleted the andy/clean-up-api-tests branch August 5, 2024 14:11
@RCGitBot RCGitBot mentioned this pull request Aug 7, 2024
Closed
jamesrb1 pushed a commit that referenced this pull request Aug 7, 2024
@aboedo @jamesrb1
Clean up API Testers (#4141)
968a536 
# API Testers cleanup

- Moves all API Testers into main RevenueCat workspace
- ensure that they all use the local build, not a hardcoded commit
- kill all the separate projects, create a single project with a
framework per test (objc api tests, swift api tests, etc, etc)
- creates a single scheme that builds all of those targets in one pass
- update relevant CI (to do)

Here's what this actually looks like: a single scheme in Xcode, which
you can test using command + U (or just build, since it effectively
works too)

<img width="515" alt="Screenshot 2024-07-31 at 6 09 33 PM"
src="https://github.com/user-attachments/assets/53882e38-f34b-4878-a11e-5d9c304e57ec">

<img width="278" alt="Screenshot 2024-07-31 at 6 09 44 PM"
src="https://github.com/user-attachments/assets/3a7a444c-36da-4c82-ab57-4aeab77adb5d">

*Note:*
Okay, I'd directly recommend _not_ reviewing the diff, since it's kind
of insane, and instead checking out the branch to see if things make
sense.
@RCGitBot RCGitBot mentioned this pull request Aug 7, 2024
Merged
MarkVillacampa pushed a commit that referenced this pull request Aug 7, 2024
@RCGitBot
[AUTOMATIC] Release/5.2.3 (#4155)
9da3afe 
**This is an automatic release.**

### Bugfixes
* Fix Paywalls crash on iOS 18 beta (#4154) via Andy Boedo (@aboedo)
### Dependency Updates
* Bump danger from 9.4.3 to 9.5.0 (#4143) via dependabot[bot]
(@dependabot[bot])
* Bump nokogiri from 1.16.6 to 1.16.7 (#4129) via dependabot[bot]
(@dependabot[bot])
* Bump fastlane from 2.221.1 to 2.222.0 (#4130) via dependabot[bot]
(@dependabot[bot])
### Other Changes
* Update deployment targets for tests (#4145) via Andy Boedo (@aboedo)
* Deploy purchaserTester: clean up dry-run parameter (#4140) via Andy
Boedo (@aboedo)
* Clean up API Testers (#4141) via Andy Boedo (@aboedo)
* More project structure cleanup (#4131) via Andy Boedo (@aboedo)
* temporarily disables purchasetester deploy (#4133) via Andy Boedo
(@aboedo)
* Fix trigger all tests branch (#4135) via Andy Boedo (@aboedo)
* Clean up XCWorkspace and testing apps (#4111) via Andy Boedo (@aboedo)
* tests trigger: add target-branch parameter to trigger from the right
branch (#4121) via Andy Boedo (@aboedo)
* Re-added the RevenueCatUI tests job on every commit (#4113) via Andy
Boedo (@aboedo)
nyeu pushed a commit that referenced this pull request Oct 2, 2024
@aboedo @nyeu
Clean up API Testers (#4141)
a72bf3c 
# API Testers cleanup

- Moves all API Testers into main RevenueCat workspace
- ensure that they all use the local build, not a hardcoded commit
- kill all the separate projects, create a single project with a
framework per test (objc api tests, swift api tests, etc, etc)
- creates a single scheme that builds all of those targets in one pass
- update relevant CI (to do)

Here's what this actually looks like: a single scheme in Xcode, which
you can test using command + U (or just build, since it effectively
works too)

<img width="515" alt="Screenshot 2024-07-31 at 6 09 33 PM"
src="https://github.com/user-attachments/assets/53882e38-f34b-4878-a11e-5d9c304e57ec">

<img width="278" alt="Screenshot 2024-07-31 at 6 09 44 PM"
src="https://github.com/user-attachments/assets/3a7a444c-36da-4c82-ab57-4aeab77adb5d">

*Note:*
Okay, I'd directly recommend _not_ reviewing the diff, since it's kind
of insane, and instead checking out the branch to see if things make
sense.
nyeu pushed a commit that referenced this pull request Oct 2, 2024
@RCGitBot @nyeu
[AUTOMATIC] Release/5.2.3 (#4155)
f3c1f6f 
**This is an automatic release.**

### Bugfixes
* Fix Paywalls crash on iOS 18 beta (#4154) via Andy Boedo (@aboedo)
### Dependency Updates
* Bump danger from 9.4.3 to 9.5.0 (#4143) via dependabot[bot]
(@dependabot[bot])
* Bump nokogiri from 1.16.6 to 1.16.7 (#4129) via dependabot[bot]
(@dependabot[bot])
* Bump fastlane from 2.221.1 to 2.222.0 (#4130) via dependabot[bot]
(@dependabot[bot])
### Other Changes
* Update deployment targets for tests (#4145) via Andy Boedo (@aboedo)
* Deploy purchaserTester: clean up dry-run parameter (#4140) via Andy
Boedo (@aboedo)
* Clean up API Testers (#4141) via Andy Boedo (@aboedo)
* More project structure cleanup (#4131) via Andy Boedo (@aboedo)
* temporarily disables purchasetester deploy (#4133) via Andy Boedo
(@aboedo)
* Fix trigger all tests branch (#4135) via Andy Boedo (@aboedo)
* Clean up XCWorkspace and testing apps (#4111) via Andy Boedo (@aboedo)
* tests trigger: add target-branch parameter to trigger from the right
branch (#4121) via Andy Boedo (@aboedo)
* Re-added the RevenueCatUI tests job on every commit (#4113) via Andy
Boedo (@aboedo)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonidero tonidero tonidero approved these changes

Assignees

@aboedo aboedo

Labels
pr:other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aboedo @RevenueCat-Danger-Bot @tonidero @vegaro