Merge pull request #116 from RevealBi/data-source/rest

Move UpdateResourceItemDataSource method to base DataSourceItem Class
RevealBi · Dec 2, 2024 · e3f13eb · e3f13eb
2 parents 13fda76 + 002a027
commit e3f13eb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/src/Reveal.Sdk.Dom/Data/DataSourceItem.cs b/src/Reveal.Sdk.Dom/Data/DataSourceItem.cs
@@ -253,5 +253,13 @@ private string ValidateRightFieldName(string fieldName, string alias)
 
             throw new ArgumentException($"Invalid right field name format: {fieldName}");
         }
+
+        protected void UpdateResourceItemDataSource(DataSource dataSource)
+        {
+            ResourceItemDataSource.Id = dataSource.Id;
+            ResourceItemDataSource.Title = dataSource.Title ?? ResourceItem.Title;
+            ResourceItemDataSource.Subtitle = dataSource.Subtitle ?? ResourceItem.Subtitle;
+            ResourceItem.DataSourceId = ResourceItemDataSource.Id;
+        }
     }
 }
diff --git a/src/Reveal.Sdk.Dom/Data/DataSourceItems/RestDataSourceItem.cs b/src/Reveal.Sdk.Dom/Data/DataSourceItems/RestDataSourceItem.cs
@@ -105,15 +105,6 @@ protected override void OnFieldsPropertyChanged(List<IField> fields)
             Parameters.Add("config", BuildConfig(fields));
         }
 
-        //todo: this may need to go on the base class. wait until more data source items are created
-        private void UpdateResourceItemDataSource(DataSource dataSource)
-        {
-            ResourceItemDataSource.Id = dataSource.Id;
-            ResourceItemDataSource.Title = dataSource.Title ?? ResourceItem.Title;
-            ResourceItemDataSource.Subtitle = dataSource.Subtitle ?? ResourceItem.Subtitle;
-            ResourceItem.DataSourceId = ResourceItemDataSource.Id;
-        }
-
         private Dictionary<string, object> BuildConfig(IEnumerable<IField> fields)
         {
             Dictionary<string, object> config = new Dictionary<string, object>();