Merge pull request #118 from RevealBi/single-value-label-Visualizatio…

…nSpec-type-change Fix parsing errors for SingleValueLabelsVisualization
RevealBi · Dec 3, 2024 · cedb27d · cedb27d
2 parents b00a88b + 7df0adc
commit cedb27d
Showing 1 changed file with 29 additions and 3 deletions.
diff --git a/src/Reveal.Sdk.Dom/Visualizations/SingleValueLabelsVisualizationBase.cs b/src/Reveal.Sdk.Dom/Visualizations/SingleValueLabelsVisualizationBase.cs
@@ -12,12 +12,38 @@ public abstract class SingleValueLabelsVisualizationBase<TSettings> : Visualizat
         protected SingleValueLabelsVisualizationBase(string title, DataSourceItem dataSourceItem) : base(title, dataSourceItem) { }
 
         [JsonIgnore]
-        public List<DimensionColumn> Labels { get { return VisualizationDataSpec.Rows; } }
+        public List<DimensionColumn> Labels { 
+            get
+            {
+                if (VisualizationDataSpec is SingleValueLabelsVisualizationDataSpec vizSpec)
+                {
+                    return vizSpec.Rows;
+                }
+                else
+                {
+                    return new List<DimensionColumn>();
+                }
+            } 
+            }
 
         [JsonIgnore]
-        public List<MeasureColumn> Values { get { return VisualizationDataSpec.Value; } }
+        public List<MeasureColumn> Values { 
+            get
+            {
+                if (VisualizationDataSpec is SingleValueLabelsVisualizationDataSpec vizSpec)
+                {
+                    return vizSpec.Value;
+                }
+                else
+                {
+                    return new List<MeasureColumn>();
+                }
+            } 
+            }
 
+
+        //Some visualizations can be assigned a CategoryVisualizationDataSpec instead of a SingleValueLabelsVisualizationDataSpec
         [JsonProperty(Order = 7)]
-        SingleValueLabelsVisualizationDataSpec VisualizationDataSpec { get; set; } = new SingleValueLabelsVisualizationDataSpec();
+        VisualizationDataSpec VisualizationDataSpec { get; set; } = new SingleValueLabelsVisualizationDataSpec();
     }
 }