Merge pull request #46 from RevealBi/add-xmla-members-and-viz-desc

Add new properties for Xmla support and visualizations
RevealBi · May 7, 2024 · a33da8d · a33da8d
2 parents 335777a + ed44f0e
commit a33da8d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/Reveal.Sdk.Dom/Visualizations/Primitives/DimensionColumn.cs b/src/Reveal.Sdk.Dom/Visualizations/Primitives/DimensionColumn.cs
@@ -21,8 +21,7 @@ public DimensionColumn(IDimensionDataField dataField) : this()
         [JsonProperty("SummarizationField")]
         public IDimensionDataField DataField { get; set; }
 
-        //todo: implement
-        [JsonProperty]
-        internal XmlaDimensionElement XmlaElement { get; set; }
+        [JsonProperty("XmlaElement")]
+        public XmlaDimensionElement XmlaElement { get; set; }
     }
 }
diff --git a/src/Reveal.Sdk.Dom/Visualizations/Primitives/MeasureColumn.cs b/src/Reveal.Sdk.Dom/Visualizations/Primitives/MeasureColumn.cs
@@ -21,8 +21,7 @@ public MeasureColumn(NumberDataField dataField) : this()
         [JsonProperty("SummarizationField")]
         public NumberDataField DataField { get; set; }
 
-        //todo: implement
-        [JsonProperty]
-        internal XmlaMeasure XmlaMeasure { get; set; }
+        [JsonProperty("XmlaMeasure")]
+        public XmlaMeasure XmlaMeasure { get; set; }
     }
 }
diff --git a/src/Reveal.Sdk.Dom/Visualizations/Visualization.cs b/src/Reveal.Sdk.Dom/Visualizations/Visualization.cs
@@ -68,6 +68,11 @@ protected Visualization(string title, DataSourceItem dataSourceItem)
         [JsonProperty("DataSpec", Order = 6)]
         public IDataDefinition DataDefinition { get; internal set; }
 
+        /// <summary>
+        /// Gets or sets the description of the visualization.
+        /// </summary>
+        public string Description { get; set; }
+
         /// <summary>
         /// Gets the data source item for the visualization.
         /// </summary>