Merge pull request #99 from RevealBi/binding-source-fix

fixed the binding source to support ParameterBindingSource

src/Reveal.Sdk.Dom/Core/Serialization/Converters/BindingSourceConverter.cs

@@ -4,7 +4,7 @@
 
 namespace Reveal.Sdk.Dom.Core.Serialization.Converters
 {
-    internal class BindingSourceConverter : TypeMapConverter<BindingSource>
+    internal class BindingSourceConverter : TypeMapConverter<IBindingSource>
     {
         public BindingSourceConverter()
         {

src/Reveal.Sdk.Dom/Filters/Bindings/Binding.cs

@@ -4,13 +4,14 @@
 
 namespace Reveal.Sdk.Dom.Filters
 {
-    public abstract class Binding<TSource, TTarget> : Binding
-        where TSource : BindingSource, new()
+    public abstract class Binding<TTarget> : Binding
         where TTarget : BindingTarget, new()
-    {
-        [JsonConverter(typeof(BindingSourceConverter))]
-        public TSource Source { get; set; }
+    {        
+        public IBindingSource Source { get; set; }
 
+        //todo: how does this work? does this need to be an interface too?
+        //if so then the parent classes may not be needed at all
+        //the filter bidnings might need a redesign
         [JsonConverter(typeof(BindingTargetConverter))]
         public TTarget Target { get; set; }
     }

src/Reveal.Sdk.Dom/Filters/Bindings/BindingTarget.cs

@@ -2,6 +2,7 @@
 
 namespace Reveal.Sdk.Dom.Filters
 {
+    //does this need to be an interface?
     public abstract class BindingTarget : SchemaType
     {
 

src/Reveal.Sdk.Dom/Filters/Bindings/DashboardDataFilterBinding.cs

@@ -1,6 +1,6 @@
 namespace Reveal.Sdk.Dom.Filters
 {
-    public sealed class DashboardDataFilterBinding : Binding<FieldBindingSource, DashboardDataFilterBindingTarget>
+    public sealed class DashboardDataFilterBinding : Binding<DashboardDataFilterBindingTarget>
     {
         internal DashboardDataFilterBinding() { }
 

src/Reveal.Sdk.Dom/Filters/Bindings/DashboardDateFilterBinding.cs

@@ -1,6 +1,6 @@
 namespace Reveal.Sdk.Dom.Filters
 {
-    public sealed class DashboardDateFilterBinding : Binding<FieldBindingSource, DashboardDateFilterBindingTarget>
+    public sealed class DashboardDateFilterBinding : Binding<DashboardDateFilterBindingTarget>
     {
         internal DashboardDateFilterBinding() : this(string.Empty) { }
 

src/Reveal.Sdk.Dom/Filters/Bindings/FieldBindingSource.cs

@@ -1,8 +1,9 @@
-using Reveal.Sdk.Dom.Core.Constants;
+using Reveal.Sdk.Dom.Core;
+using Reveal.Sdk.Dom.Core.Constants;
 
 namespace Reveal.Sdk.Dom.Filters
 {
-    public sealed class FieldBindingSource : BindingSource
+    public sealed class FieldBindingSource : SchemaType, IBindingSource
     {
         public string FieldName { get; set; }
 

src/Reveal.Sdk.Dom/Filters/Bindings/ParameterBindingSource.cs

@@ -1,7 +1,15 @@
-namespace Reveal.Sdk.Dom.Filters
+using Reveal.Sdk.Dom.Core;
+using Reveal.Sdk.Dom.Core.Constants;
+
+namespace Reveal.Sdk.Dom.Filters
 {
-    public sealed class ParameterBindingSource : BindingSource
+    public sealed class ParameterBindingSource : SchemaType, IBindingSource
     {
         public string ParameterName { get; set; }
+
+        public ParameterBindingSource()
+        {
+            SchemaTypeName = SchemaTypeNames.ParameterBindingSourceType;
+        }
     }
 }

src/Reveal.Sdk.Dom/Filters/Interfaces/IBindingSource.cs

@@ -0,0 +1,10 @@
+using Newtonsoft.Json;
+using Reveal.Sdk.Dom.Core.Serialization.Converters;
+
+namespace Reveal.Sdk.Dom.Filters
+{
+    [JsonConverter(typeof(BindingSourceConverter))]
+    public interface IBindingSource
+    {
+    }
+}