Skip to content

Commit

Permalink
Your commit message
Browse files Browse the repository at this point in the history
  • Loading branch information
recca5p committed Dec 12, 2024
1 parent a632870 commit 1684ba1
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 31 deletions.
19 changes: 0 additions & 19 deletions e2e/Sandbox/DashboardCreators/MySqlDashboard.cs

This file was deleted.

4 changes: 2 additions & 2 deletions e2e/Sandbox/DashboardCreators/MySqlDataSourceDashboards.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ public class MySqlDataSourceDashboards : IDashboardCreator

public RdashDocument CreateDashboard()
{
var mysqlDS = new MySQLDataSource
var mysqlDS = new MySqlDataSource
{
Id = "mysqlDS",
Title = "MySQL DS",
Subtitle = "My SQL Datasource",
Host = "revealdb01.infragistics.local",
Database = "northwind",
Port = "3306",
Port = 3306,
};

var mysqlDSItem = new MySqlDataSourceItem("employees report to ID", mysqlDS)
Expand Down
2 changes: 1 addition & 1 deletion e2e/Sandbox/MainWindow.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public partial class MainWindow : Window
new MSAnalysisServiceDashboard(),
new MSAzureAnalysisServiceDashboard(),
new MSAzureSqlDashboard(),
new MySqlDashboard(),
new MySqlDataSourceDashboards(),
new MSAzureSqlServerDSDashboard(),
new ODataDashboard(),
new OracleDashboard(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class MySqlDataSourceItemFixture
public void Constructor_SetsTitleAndDataSource_WhenCalled(string title)
{
// Arrange
var dataSource = new MySQLDataSource();
var dataSource = new MySqlDataSource();

// Act
var item = new MySqlDataSourceItem(title, dataSource);
Expand All @@ -34,7 +34,7 @@ public void Constructor_SetsTitleAndDataSource_WhenCalled(string title)
public void ProcessDataOnServer_SetsAndGetsServerAggregationValue_WithInputs()
{
// Arrange
var item = new MySqlDataSourceItem("Test Item", new MySQLDataSource());
var item = new MySqlDataSourceItem("Test Item", new MySqlDataSource());

// Act
item.ProcessDataOnServer = true;
Expand Down Expand Up @@ -80,7 +80,7 @@ public void ToJsonString_CreatesFormattedJson_ForMySQLDataSource()
}
""";

var dataSource = new MySQLDataSource()
var dataSource = new MySqlDataSource()
{
Id = "mySqlId",
Title = "MySQL DS",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class MySQLDataSourceFixture
public void Constructor_SetsProviderToMySQL_WhenConstructed()
{
// Act
var dataSource = new MySQLDataSource();
var dataSource = new MySqlDataSource();

// Assert
Assert.Equal(DataSourceProvider.MySQL, dataSource.Provider);
Expand All @@ -28,7 +28,7 @@ public void Constructor_SetsProviderToMySQL_WhenConstructed()
public void Constructor_InitializesPropertiesToDefaultValues_WhenInstanceIsCreated()
{
// Act
var dataSource = new MySQLDataSource();
var dataSource = new MySqlDataSource();

// Assert
Assert.NotNull(dataSource);
Expand Down Expand Up @@ -74,7 +74,7 @@ public void ToJsonString_CreatesFormattedJson_ForMySQLDataSource()
}
""";

var dataSource = new MySQLDataSource()
var dataSource = new MySqlDataSource()
{
Id = "mySqlId",
Title = "MySQL DS",
Expand Down
12 changes: 11 additions & 1 deletion src/Reveal.Sdk.Dom/Data/DataSourceItems/MySqlDataSourceItem.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,16 @@ namespace Reveal.Sdk.Dom.Data
{
public class MySqlDataSourceItem : ProcedureDataSourceItem, IProcessDataOnServer
{
public MySqlDataSourceItem(string title, string table, MicrosoftSqlServerDataSource dataSource) :
this(title, dataSource)
{
Table = table;
}

public MySqlDataSourceItem(string title, MySqlDataSource dataSource) :
base(title, dataSource)
{ }

public MySqlDataSourceItem(string title, DataSource dataSource) :
base(title, dataSource)
{ }
Expand All @@ -18,7 +28,7 @@ public bool ProcessDataOnServer

protected override DataSource CreateDataSourceInstance(DataSource dataSource)
{
return Create<MySQLDataSource>(dataSource);
return Create<MySqlDataSource>(dataSource);
}
}
}
4 changes: 2 additions & 2 deletions src/Reveal.Sdk.Dom/Data/DataSources/MySQLDataSource.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

namespace Reveal.Sdk.Dom.Data
{
public class MySQLDataSource : ProcessDataSource
public class MySqlDataSource : ProcessDataSource
{
public MySQLDataSource()
public MySqlDataSource()
{
Provider = DataSourceProvider.MySQL;
}
Expand Down

0 comments on commit 1684ba1

Please sign in to comment.