Re #48 manually handle signals in wobbler example #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rethink-imcmahon
force-pushed
the
rospy_simulated_wobbler_fix
branch
from
919611d to
57a0e16
Compare
This commit removes reliance on rospy for handling the shutdown behavior when a Ctrl+C signal is asserted on the joint_velocity_wobbler example. Cleanup was not properly being executed in only the simulated robot through rospy's on_shutdown() callback handler. This change has been tested on both the simulated and real Baxter robots.
rethink-imcmahon
force-pushed
the
rospy_simulated_wobbler_fix
branch
from
57a0e16 to
b884675
Compare
|
Either this should get fixed in all 13 of our examples with on_shutdown behavior or the root cause needs to be sussed out in |
|
Appears there was an underlying This PR is no longer needed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes reliance on rospy for handling the shutdown
behavior when a Ctrl+C signal is asserted on the joint_velocity_wobbler
example. Cleanup was not properly being executed in only the
simulated robot through rospy's on_shutdown() callback handler. This
change has been tested on both the simulated and real Baxter robots.