Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove async_trait macro in favor of AFIT & RPITIT #211

Merged
merged 11 commits into from
Jan 31, 2024
Merged

Remove async_trait macro in favor of AFIT & RPITIT #211

merged 11 commits into from
Jan 31, 2024

Conversation

thomaseizinger
Copy link
Collaborator

@thomaseizinger thomaseizinger commented Sep 29, 2023 •
edited
Loading

Resolves: #202.

Restioson
Restioson reviewed Sep 29, 2023
View reviewed changes
Copy link
Owner

@Restioson Restioson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! I'm surprised that MessageEnvelope didn't need any changes

@thomaseizinger
Copy link
Collaborator Author

rust-lang/rust#115822 just merged which will be stable in Rust 1.75 on December 28th! 🥳

@Restioson
Copy link
Owner

Woo! Awesome!

@thomaseizinger thomaseizinger changed the title Experiment with async fn in traits Remove async_trait macro in favor of AFIT & RPITIT Dec 6, 2023
@thomaseizinger
Copy link
Collaborator Author

@Restioson I think this is now ready for being merged once 1.75 is released.

@thomaseizinger thomaseizinger marked this pull request as ready for review December 6, 2023 22:35
@Restioson
Copy link
Owner

Awesome! 🎉

@thomaseizinger
Copy link
Collaborator Author

@Restioson This is now ready to be merged!

@Restioson Restioson merged commit c836eb0 into master Jan 31, 2024
6 checks passed
@Restioson Restioson deleted the async-fn-traits branch January 31, 2024 18:42
@thomaseizinger
Copy link
Collaborator Author

Shall we release 0.6 finally? 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Restioson Restioson Restioson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Experiment with nightly async fn in traits
2 participants
@thomaseizinger @Restioson