Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud name validation regex and error message inconsistent #9

Open
lfielke opened this issue May 2, 2014 · 1 comment
Open

Cloud name validation regex and error message inconsistent #9

lfielke opened this issue May 2, 2014 · 1 comment

Comments

@lfielke
Copy link
Contributor

lfielke commented May 2, 2014

When trying to log into at https://cspote.neustar.biz/onexus/cloudPage an error message is shown if an "invalid" cloud name is entered:

Cloudname should begin with '=' , it should not have any spaces or '*' and it should not end with a '.'

The validation regex (net.respectnetwork.csp.application.manager.RegistrationManager#CloudNameRegEx) is inconsistent with these rules. Eg:

  • =entrée arguably should be valid according to the error message but doesn't pass the regex
  • =mc-hammer passes the validation regex, but - are not mentioned in the message

I'm not sure what the actual validation rules are, but it doesn't look very pretty at the moment.

Also the error message has a space before the first comma, which is probably a typo.

@animeshc
Copy link
Contributor

animeshc commented May 2, 2014

You are right. I didn't want to put the whole blurb of what makes a valid
cloudname. But, that makes the check and the error text inconsistent. So,
I've added the appropriate error message.
Thanks,
Animesh

On Thu, May 1, 2014 at 8:43 PM, Luke Fielke [email protected]:

When trying to log into at https://cspote.neustar.biz/onexus/cloudPage an
error message is shown if an "invalid" cloud name is entered:

Cloudname should begin with '=' , it should not have any spaces or '*' and
it should not end with a '.'

The validation regex (
net.respectnetwork.csp.application.manager.RegistrationManager#CloudNameRegEx)
is inconsistent with these rules. Eg:

  • =entrée arguably should be valid according to the error message but
    doesn't pass the regex
  • =mc-hammer passes the validation regex, but - are not mentioned in
    the message

I'm not sure what the actual validation rules are, but it doesn't look
very pretty at the moment.

Also the error message has a space before the first comma, which is
probably a typo.


Reply to this email directly or view it on GitHubhttps://github.com//issues/9
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants