[EN-7871] Help need wording - candidate refering context #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillobits
temporarily deployed
to
entourage-job-front
GitHub Actions
Inactive
Default Project
|
||||||||||||||||||||||||||||||
| Project |
Default Project
|
| Branch Review |
feature/EN-7871-Page-Choix-des-types-de-coup-de-pouce-du-Candidat-orient-clarifier
|
| Run status |
|
| Run duration | 06m 05s |
| Commit |
|
| Committer | CAUCHOIS Guillaume |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
42
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
DDZBX
reviewed
Dec 18, 2024
Comment on lines
14
to
16
| options: ParametresHelpCardContents[USER_ROLES.CANDIDATE], | ||
| options: ReferingCandidateHelpCardContents, |
There was a problem hiding this comment.
Un peu dommage de pas pouvoir ajouter une valeur dans ParametresHelpCardContents, mais je vois pourquoi c'est chiant
Pour le naming ca serait plutot ReferedCandidateHelpCardContents ? Parce qu'ici on parle du candidat qu'on va orienté pas du prescripteur, qu'en penses tu ?
There was a problem hiding this comment.
Ouais je m'étais posé la question pour ParametresHelpCardContents mais comme t'as dit c'est galère et ça demanderait d'ajouter un contexte dans lequel j'utilise le help est-ce que c'est du refering ou de la registration classique
Ok pour le nom par contre ;)
guillobits
temporarily deployed
to
entourage-job-front
GitHub Actions
Inactive
DDZBX
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.