Fix issue with adding valid DOIs to ref manager #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kerkelae is attempting to deploy a commit to the ResearchHub Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve ResearchHub/issues#34.
The issue seems to have been
issn.joinfailing ifissnisnullor not an array. The fix involves adding a check to ensureissnis an array before calling thejoinmethod. The updated code usesArray.isArray(issn) ? issn.join(", ") : "", which checks ifissnis an array; if it is, it joins the array elements into a string separated by commas. Ifissnis not an array or isnull, it defaults to an empty string. This prevents the application from throwing an error when trying to calljoinon anullvalue.I ran the code locally and was able to add the DOI that caused the issue: