Allow create paper with no doi #1942
Open
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1942 +/- ##
==========================================
- Coverage 64.04% 64.03% -0.02%
==========================================
Files 406 406
Lines 23590 23591 +1
==========================================
- Hits 15108 15106 -2
- Misses 8482 8485 +3 ☔ View full report in Codecov by Sentry. |
yattias
reviewed
Oct 25, 2024
| duplicate_papers = Paper.objects.filter(doi=doi) | ||
| if duplicate_papers.exists(): | ||
| serializer = DynamicPaperSerializer( | ||
| duplicate_papers[:1], |
There was a problem hiding this comment.
This line a bit confusing. I'm sure it's not the case, but seems arbitrary to select [:1]. Maybe we can alias?
yattias
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: ResearchHub/issues#139