feat: Create new API for uploading papers #1932
Open
+202
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzurowski
force-pushed
the
paper-upload-api
branch
from
f480167
to
6b21892
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1932 +/- ##
==========================================
+ Coverage 64.05% 64.10% +0.05%
==========================================
Files 409 412 +3
Lines 23579 23612 +33
==========================================
+ Hits 15104 15137 +33
Misses 8475 8475 ☔ View full report in Codecov by Sentry. |
yattias
approved these changes
Oct 22, 2024
The client sends a PUT request to the presigned URL with the payload of the file in the message body. This follows the existing implementation in the frontend: https://github.com/ResearchHub/researchhub-web/blob/aa00c1992b156f0ab89458643878c15ff788b5ab/components/ReferenceManager/references/api/postUploadPDFFiles.ts#L49. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new API (
/paper/upload) for creating pre-signed URLs, so that the caller can upload papers directly to S3. This will be the first step when submitting new papers to RH.Closes ResearchHub/issues#131