[meta] Fix redirection issues on E10s #721
Comments
myrdd
added a commit
that referenced
this issue
Oct 30, 2015
On E10s there was an error in the "http-on-examine-response" observer, specifically in the function `eventuallyShowRedirectNotification()`. The function checks if the load corresponding to the request is a top-level document request. If true, the redirection notification is shown. The function used the DocShell's "busy" flags, but the DocShell lives in the content process. The solution is to use the channel's load flags instead. It's compatible with E10s and it's even less code. However, the redirection notification still isn't shown on http://www.maindomain.test/redirect-http-location-header-png.php because there are more issues. See also #721.
|
wontfix. RP will be a webextension. --> #704 |
jrrdev
pushed a commit
to jrrdev/requestpolicy
that referenced
this issue
Nov 22, 2017
On E10s there was an error in the "http-on-examine-response" observer, specifically in the function `eventuallyShowRedirectNotification()`. The function checks if the load corresponding to the request is a top-level document request. If true, the redirection notification is shown. The function used the DocShell's "busy" flags, but the DocShell lives in the content process. The solution is to use the channel's load flags instead. It's compatible with E10s and it's even less code. However, the redirection notification still isn't shown on http://www.maindomain.test/redirect-http-location-header-png.php because there are more issues. See also RequestPolicyContinued#721.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When E10s is enabled, the redirection notification bar (r21n) has several issues. There are already Marionette unit tests for some of those issues [1], but however it's not trivial to solve those issues. Probably the r21n issues depend on #610.
[1] https://github.com/RequestPolicyContinued/requestpolicy/tree/dev-1.0/tests/marionette/tests/redirections
The text was updated successfully, but these errors were encountered: