Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] add link checker #467

Merged
merged 8 commits into from
Apr 23, 2024
Merged

[MAINT] add link checker #467

merged 8 commits into from
Apr 23, 2024

Conversation

Remi-Gau
Copy link
Collaborator

No description provided.

@yibeichan yibeichan mentioned this pull request Apr 22, 2024
@yibeichan
Copy link
Contributor

one of our labmates asked satra about the above, here was satra's answer: "Those are uri not URL. They aren't expected to resolve. Think of them as keys"
So we can keep them there @satra right?

fixed in #476

fixed in #476

fixed in #476

  • templates/redcap2rs.yaml

fixed in #476

cool cool, I guess we can merge this one and #476 together?

@Remi-Gau
Copy link
Collaborator Author

one of our labmates asked satra about the above, here was satra's answer: "Those are uri not URL. They aren't expected to resolve. Think of them as keys" So we can keep them there @satra right?

Then should I add an ignore pattern in this config file?

mlc_config.json

@satra
Copy link
Contributor

satra commented Apr 22, 2024

So we can keep them there @satra right?

yes, for the moment. as a basic start we could create a schema repo and put the linkml generated documentation for the schema there. (just to make sure that we get uri's correct). in the future, we could consider turning it into a service (we had this in the past).

@yibeichan
Copy link
Contributor

sounds good. @Remi-Gau can you add it to the config file to be ignored?
I'll talk to @djarecka about "create a schema repo and put the linkml generated documentation for the schema"

mlc_config.json Outdated Show resolved Hide resolved
@Remi-Gau
Copy link
Collaborator Author

maybe let's merge #476 and then I can rebase this PR to make sure everything is green

@yibeichan
Copy link
Contributor

done!

mlc_config.json Outdated Show resolved Hide resolved
mlc_config.json Outdated Show resolved Hide resolved
mlc_config.json Outdated Show resolved Hide resolved
mlc_config.json Outdated Show resolved Hide resolved
@yibeichan yibeichan merged commit a3f320e into ReproNim:master Apr 23, 2024
2 of 3 checks passed
@Remi-Gau Remi-Gau deleted the link_check branch June 17, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants