Removed unnecessary use of this

Repin-Daniil · Jan 25, 2024 · 93af86b · 93af86b
1 parent e5a73c2
commit 93af86b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/Rational/rational.cpp b/Rational/rational.cpp
@@ -10,8 +10,8 @@ Rational::Rational(int numerator, int denominator) {
     throw RationalDivisionByZero{};
   }
 
-  this->numerator_ = numerator;
-  this->denominator_ = denominator;
+  numerator_ = numerator;
+  denominator_ = denominator;
 
   Reduce();
 }
@@ -48,8 +48,8 @@ void Rational::Reduce() {
   numerator_ /= gcd;
   denominator_ /= gcd;
 
-  this->numerator_ = (denominator_ < 0) ? -numerator_ : numerator_;
-  this->denominator_ = (denominator_ < 0) ? -denominator_ : denominator_;
+  numerator_ = (denominator_ < 0) ? -numerator_ : numerator_;
+  denominator_ = (denominator_ < 0) ? -denominator_ : denominator_;
 }
 
 Rational &Rational::operator+=(const Rational &other) {

diff --git a/Rational/rational.h b/Rational/rational.h
@@ -15,7 +15,7 @@ class Rational {
  public:
   // Constructors
   Rational();
-  Rational(int p, int q = 1);  // NOLINT
+  Rational(int numerator, int denominator = 1);  // NOLINT
   Rational(const Rational &);
 
   // Setters
@@ -37,12 +37,12 @@ class Rational {
   Rational &operator--();    // Prefix decrement
   Rational operator--(int);  // Postfix decrement
 
+ private:
+  void Reduce();
+
  private:
   int numerator_;
   int denominator_;
-
-  // Methods
-  void Reduce();
 };
 
 // Operators overloading