Make Background Transparent for Android #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john1jan
reviewed
Oct 27, 2017
| final Canvas canvas = new Canvas(signatureBitmap); | ||
| this.draw(canvas); | ||
|
|
||
| // The signatureBitmap now contains the signature with a white background, | ||
| // so we will change it to a transparent background. | ||
| for (int x = 0; x < signatureBitmap.getWidth(); x++) { |
There was a problem hiding this comment.
there are two for loops. What about the performance of the component ? Did you do any performance test.
|
@jedt any update on this |
|
I'm closing this in favor of #97. It's been over a year since I opened this, so I doubt it's going to be merged anyhow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86. This PR maps the white background pixels for signature Bitmaps to transparent pixels. This way on both Android and iOS, the signature PNGs will have transparent backgrounds.