v4.7.63 several bug fixes and improvements

RensTillmann · Aug 18, 2019 · fd20f35 · fd20f35
1 parent 54f676e
commit fd20f35
Show file tree

Hide file tree

Showing 13 changed files with 191 additions and 183 deletions.
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -1,5 +1,11 @@
-### Aug 18, 2019 - Version 4.7.61
-- Fix: Bug in back-end (when `Retrieve Last Entry Data` enabled) with CSV retrieve method and dropdowns + autosuggest fields not correctly setting the field value/selection based on users last entry data
+### Aug 18, 2019 - Version 4.7.63
+- Added: `US States` dropdown element
+- Changed: `Countries` dropdown element will no longer use the `contries.txt` to retrieve items, instead you can now use the `Custom items` method to change the list. This was not possible with coutries.txt when updating super forms changes would be lost.
+- Fix: Make sure the `Default value` for `Rating` element is of type `int`.
+- Fix: Bug with `Dynamic Columns` in combination with `Retrieve form data from users last submission` upon adding a new dynamic column the `Default value` would be incorrect.
+- Fix: Bug with `Signature Add-on` and `Color picker` not initializing upon dragging it on the canvas (due to Envato rules `¯\_(ツ)_/¯`)
+- Fix: Bug with checkbox/radio items not being updated upon "Update Element"
+- Removed: Skype element, API doesn't exist anymore
 
 ### Aug 15, 2019 - Version 4.7.60
 - Added: [Data Storage](data-storage) section in documentation describing where specific data being stored by super forms
@@ -675,7 +681,6 @@
 - Fix: Checkbox images retrieving thumbnail version, now returning original image
 - Fix: Issue with font-awesome stylesheet not having a unique name, changed it to super-font-awesome
 - Fix: {tag} in HTML element not displaying negative calculator value correctly
-- Fix: Insecure content loaded skypeassets back-end and front-end
 - Added: Option to update conditional logic dynamically when using dynamic fields (add more +)
 - Added: JS action hook: SUPER.after_responsive_form_hook()
 - Added: JS action hook: SUPER.after_duplicate_column_fields_hook()
@@ -816,7 +821,6 @@
 - Fix: Color settings for custom button not being retrieved correctly when editing button
 - Fix: z-index on Save/Clear/Edit/Preview actions lowered due to overlapping the WP admin bar
 - Fix: Dropdown with Icon inside field and right aligned arrow is hidden below the Icon
-- Fix: Skype rerendering in backend after adding other elements
 - Improved: Bug fixed combination columns inside multipart
 - Improved: Conditional logic (contains ??) in combination with checkbox/dropdown with multi select
 - Improved: When reCAPTCHA key or secret is not filled out, show a notice to the user

diff --git a/src/add-ons/super-forms-signature/assets/js/frontend/signature.js b/src/add-ons/super-forms-signature/assets/js/frontend/signature.js
@@ -32,22 +32,24 @@
 
 	// Refresh Signature (Refresh the appearance of the signature area.)
 	SUPER.refresh_signature = function($changed_field, $form, $skip, $do_before, $do_after){
-		if($changed_field.parents('.super-signature:eq(0)')){
-            var $skip = false;
-            $changed_field.parents('.super-shortcode.super-column').each(function(){
-                if($(this).css('display')=='none') {
+        if(typeof $changed_field !== 'undefined'){
+            if($changed_field.parents('.super-signature:eq(0)')){
+                var $skip = false;
+                $changed_field.parents('.super-shortcode.super-column').each(function(){
+                    if($(this).css('display')=='none') {
+                        $skip = true;
+                    }
+                });
+                var $parent = $changed_field.parents('.super-shortcode:eq(0)');
+                if( ( $parent.css('display')=='none' ) && ( !$parent.hasClass('super-hidden') ) ) {
                     $skip = true;
                 }
-            });
-            var $parent = $changed_field.parents('.super-shortcode:eq(0)');
-            if( ( $parent.css('display')=='none' ) && ( !$parent.hasClass('super-hidden') ) ) {
-                $skip = true;
-            }
-            if( $skip===false ) {
-				var $canvas = $changed_field.parents('.super-signature:eq(0)').find('.super-signature-canvas');
-				$canvas.signature('resize');
+                if( $skip===false ) {
+                    var $canvas = $changed_field.parents('.super-signature:eq(0)').find('.super-signature-canvas');
+                    $canvas.signature('resize');
+                }
             }
-		}
+        }
 	};
 
     // @since 1.2.2 - remove initialized class from signature element after the column has been cloned
@@ -86,4 +88,4 @@
 
 	});
 
-})(jQuery);	
+})(jQuery);	
diff --git a/src/assets/css/frontend/elements.css b/src/assets/css/frontend/elements.css
diff --git a/src/assets/css/frontend/elements.css.map b/src/assets/css/frontend/elements.css.map
diff --git a/src/assets/css/frontend/elements.sass b/src/assets/css/frontend/elements.sass
@@ -851,9 +851,6 @@ textarea
 .super-field
   &.super-spacer, &.super-remove-margin, &.super-divider
     margin: 0px 0px 0px 0px
-  &.super-skype
-    z-index: 1
-    position: relative
   &.hidden, &.super-hidden
     display: none
 
@@ -2446,7 +2443,7 @@ ul.super-multipart-steps .super-multipart-step
   .super-field
     .super-label, .super-description, .super-field-wrapper .super-shortcode-field
       text-align: right
-  .super-skype-button, .super-html .super-html-content
+  .super-html .super-html-content
     text-align: right
   .super-field.super-quantity .super-field-wrapper .super-shortcode-field
     text-align: center

diff --git a/src/assets/js/common.js b/src/assets/js/common.js
@@ -4059,6 +4059,15 @@ function SUPERreCaptcha(){
                 $value = '',
                 $field = $element.parents('.super-field:eq(0)'),
                 $default_value = $element.data('default-value');
+
+            if($form.hasClass('super-duplicate-column-fields')){
+                // In this case we will want to get the default value from `data-absolute-default` attribute
+                if(typeof $element.attr('data-absolute-default')!=='undefined'){
+                    $default_value = $element.attr('data-absolute-default');
+                }else{
+                    $default_value = '';
+                }
+            }
 
             // Checkbox and Radio buttons
             if( $field.hasClass('super-checkbox') || $field.hasClass('super-radio') ){
@@ -4660,9 +4669,6 @@ function SUPERreCaptcha(){
         //Init button colors
         SUPER.init_button_colors();
 
-        //Init skype
-        SUPER.init_skype();
-
         //Init dropdowns
         SUPER.init_dropdowns();
 
@@ -4875,7 +4881,6 @@ function SUPERreCaptcha(){
 
     // Init common fields to init
     SUPER.init_common_fields = function(){
-        SUPER.init_skype();
         SUPER.init_tooltips();
         SUPER.init_datepicker();
         SUPER.init_masked_input();
@@ -4884,6 +4889,10 @@ function SUPERreCaptcha(){
         SUPER.init_slider_field();
         SUPER.init_button_colors();
         SUPER.init_text_editors();
+        // Check if function exists
+        if(typeof SUPER.init_signature === 'function'){
+            SUPER.init_signature();
+        }
     };
 
     // Handle the responsiveness of the form

diff --git a/src/assets/js/frontend/elements.js b/src/assets/js/frontend/elements.js
@@ -1,4 +1,4 @@
-/* globals jQuery, SUPER, Skype, super_elements_i18n */
+/* globals jQuery, SUPER, super_elements_i18n */
 "use strict";
 (function($) { // Hide scope, no $ conflict
 
@@ -13,23 +13,6 @@
         });
     };
 
-    // init Skype
-    SUPER.init_skype = function(){
-        $('.super-skype-button').each(function(){
-            var $parent = $(this).parents('.super-skype:eq(0)');
-            if(!$parent.hasClass('super-rendered')){
-                $parent.addClass('super-rendered');
-                Skype.ui({
-                    "name": $(this).data('method'),
-                    "element": $(this).attr('id'),
-                    "participants": [$(this).data('username')],
-                    "imageSize": $(this).data('size'),
-                    "imageColor": $(this).data('color'),
-                });
-            }
-        });
-    };
-
     // @since 1.3   - input mask
     SUPER.init_masked_input = function(){
         $('.super-shortcode-field[data-mask]').each(function(){
@@ -58,7 +41,7 @@
         });
     };
 
-    // @since 2.0 - calculate age in years, months and days
+    // @since 2.0 - initialize color picker(s) 
     SUPER.init_colorpicker = function(){
         $('.super-color .super-shortcode-field').each(function(){
             if(typeof $.fn.spectrum === "function") { 
@@ -470,16 +453,9 @@
         $('.super-timepicker').on('changeTime', function() {
             set_timepicker_dif($(this));
         });
-
         $('.super-timepicker').parent().find('.super-icon').on('click',function(){
             $(this).parent().find('.super-timepicker').timepicker('show');
         });
-        $('.super-timepicker').on('click focus',function(){
-            if($('.super-datepicker').length){
-                $('.super-datepicker').datepicker('hide');
-            }
-            $(this).timepicker('show');
-        });
     };
 
     // Initialize button colors
@@ -660,7 +636,6 @@
     jQuery(document).ready(function ($) {
 
         SUPER.init_dropdowns();
-        SUPER.init_skype();
         SUPER.init_datepicker();
         SUPER.init_masked_input();
         SUPER.init_currency_input();

diff --git a/src/docs/changelog.md b/src/docs/changelog.md
@@ -1,6 +1,11 @@
-### Aug 18, 2019 - Version 4.7.62
-- Fix: Bug in back-end (when `Retrieve Last Entry Data` enabled) with CSV retrieve method and dropdowns + autosuggest fields not correctly setting the field value/selection based on users last entry data
+### Aug 18, 2019 - Version 4.7.63
+- Added: `US States` dropdown element
+- Changed: `Countries` dropdown element will no longer use the `contries.txt` to retrieve items, instead you can now use the `Custom items` method to change the list. This was not possible with coutries.txt when updating super forms changes would be lost.
+- Fix: Make sure the `Default value` for `Rating` element is of type `int`.
+- Fix: Bug with `Dynamic Columns` in combination with `Retrieve form data from users last submission` upon adding a new dynamic column the `Default value` would be incorrect.
+- Fix: Bug with `Signature Add-on` and `Color picker` not initializing upon dragging it on the canvas (due to Envato rules `¯\_(ツ)_/¯`)
 - Fix: Bug with checkbox/radio items not being updated upon "Update Element"
+- Removed: Skype element, API doesn't exist anymore
 
 ### Aug 15, 2019 - Version 4.7.60
 - Added: [Data Storage](data-storage) section in documentation describing where specific data being stored by super forms
@@ -676,7 +681,6 @@
 - Fix: Checkbox images retrieving thumbnail version, now returning original image
 - Fix: Issue with font-awesome stylesheet not having a unique name, changed it to super-font-awesome
 - Fix: {tag} in HTML element not displaying negative calculator value correctly
-- Fix: Insecure content loaded skypeassets back-end and front-end
 - Added: Option to update conditional logic dynamically when using dynamic fields (add more +)
 - Added: JS action hook: SUPER.after_responsive_form_hook()
 - Added: JS action hook: SUPER.after_duplicate_column_fields_hook()
@@ -817,7 +821,6 @@
 - Fix: Color settings for custom button not being retrieved correctly when editing button
 - Fix: z-index on Save/Clear/Edit/Preview actions lowered due to overlapping the WP admin bar
 - Fix: Dropdown with Icon inside field and right aligned arrow is hidden below the Icon
-- Fix: Skype rerendering in backend after adding other elements
 - Improved: Bug fixed combination columns inside multipart
 - Improved: Conditional logic (contains ??) in combination with checkbox/dropdown with multi select
 - Improved: When reCAPTCHA key or secret is not filled out, show a notice to the user