Used string comparisons ignoring case #226
Conversation
E3Next/Utility/e3util.cs
Outdated
| @@ -65,6 +65,12 @@ public static void PutOriginalTargetBackIfNeeded(Int32 targetid) | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| public static Boolean CompareInsensitive(this string str, string compareStr) | |||
There was a problem hiding this comment.
change to EqualsIns , as its an equal operator and insensitive is a large word. Otherwise exactly what I meant
There was a problem hiding this comment.
Wee, now I know how to make extensions in C#
There was a problem hiding this comment.
Happy to call it whatever, even string.RekkaEqic(user) :)
| @@ -701,7 +701,7 @@ private static void RegisterEvents() | |||
| { | |||
| string user = x.args[0]; | |||
|
|
|||
| if (user == E3.CurrentName) | |||
There was a problem hiding this comment.
forgot to do the spawn.DisplayName == E3.CurrentName types
There was a problem hiding this comment.
i just found all occurances of E3.CurrentName
There was a problem hiding this comment.
Also, have to remove the places where the first character is now upper cased as we are allowing anything to be in the config file and making it non case sensitive, so casting target will also have to use the new compairson i think
There was a problem hiding this comment.
thankfully TryByName in the spawns class is case insensitive already
There was a problem hiding this comment.
I left spawn.DisplayName == CurrentName, since I wasn't sure if we wanted to keep those case comparisons and that seemed intentional. It sounds like everything can be case insensitive then? Or are there cases we do care about case?
There was a problem hiding this comment.
other than using the containskey in said if staement
There was a problem hiding this comment.
I was just tracing usage of target for so casting target will also have to use the new compairson i think.
string target = E3.CurrentName
if (!_spawns.TryByName(target, out var spawn)) { }
So target should be fine, as getting/setting should be non case sensitive? At least in buffCheck
And
if (_spawns.TryByName(spell.CastTarget, out var spawn))
There was a problem hiding this comment.
if you read up in the comments, i already said trybyname was fine as it wasn't case sensitive :) its the other stuff tho
There was a problem hiding this comment.
basically anything with a == marks :P
There was a problem hiding this comment.
Oh, well then trybyname is fine :p. I was just trying to be exhaustive around other usages. Only things I saw was the target = E3.CurrentName, Spell.CastTarget = CharacterName, and e3.firstCharToUpper. But my traces seemed like they'd be okay?
Unsure which of these comparisons needed DisplayName, thought about adding an extension to String for string.caseInsensitive, adding E3.CurrentDisplayName, or a convenience method on E3.
Note: I left the following comparisons as they looked like they wanted case sensitivity