Fix Y misscale in GEMV for some cases #787
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the description,$M$ or $N$ could be zero. It is expected that the vector $\mathbf{y}$ will be correctly scaled by scalar for such cases.
For example, let GEMV computes
$\mathbf{y} := 0 \cdot \mathbf{y} + \mathbf{A}\mathbf{x}$ $\mathbf{x}$ is zero length vector. It is expected, that $\mathbf{y} = 0$ after GEMV, but it is not scaled due to statement in implementation:
and
This pull request is objected to fix the behavior in such cases.