ILP windows fix #624
Merged
ILP windows fix #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
long's in windows are 4 bytes (MSVS, intel compilers). Use int64_t and int32_t to ensure 8 byte integers for ILP interface. support 8 byte integer flag for intel ifort compiler
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1894 1894
Lines 184021 184021
=======================================
Misses 184021 184021 Continue to review full report at Codecov.
|
ajaypanyala
reviewed
Dec 14, 2021
| set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -integer-size 64") | ||
| endif() | ||
| else() | ||
| set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fdefault-integer-8") |
There was a problem hiding this comment.
@weslleyspereira The logic in #617 needs to go here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CBLAS and LAPACKE layers are not built with 8 byte integers when cmake option BUILD_INDEX64=ON is passed.
The reason is because long's in windows are 4 bytes (MSVC c/c++, intel compilers). This patch uses int64_t and int32_t
to ensure ILP interface is built.
Additionally, this patch adds support ifort's 8 byte integer flag to cmake system for building BLAS and LAPACK.
Checklist