Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare project dependency on C to avoid the CMAKE default of C,C++ #1044

Merged

Conversation

martin-frbg
Copy link
Collaborator

@martin-frbg martin-frbg commented Aug 20, 2024

Description
#834 had removed all language requirements from the project command in the toplevel CMakeLists.txt in order to move the dependencies on a Fortran compiler to those subprojects that actually need them (and make LAPACKE buildable without one).
However, the default in CMAKE is to assume a project dependency on both C and C++ if no language was
expressly requested. In the absence of any actual C++ code, this creates a spurious dependency that can prevent building
LAPACK on systems where such a compiler is not available or at least not installed by default. (This was noted in a comment on #988)

@martin-frbg
Copy link
Collaborator Author

the two CI errors on Mac appear to be caused by an update of the underlying image "macos-latest" to a version that no longer provides the gcc-11/gfortran-11 named in the build command. At a guess these would be replaced by version 13 or 14

@martin-frbg
Copy link
Collaborator Author

Indeed the "macos-latest" image has been updated from 14.6 to 14.6.1 recently, and following the embedded link in the CI log to the list of installed software in that runner image leads to a message stating that gcc-11 was to be removed from all images on August 12 actions/runner-images#10213

@martin-frbg martin-frbg merged commit 2cbabee into Reference-LAPACK:master Aug 21, 2024
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants