Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add One Pixel Snap Button to the Tile Data Editor #726

Merged

Conversation

valkyrienyanko
Copy link
Contributor

@valkyrienyanko valkyrienyanko commented Oct 16, 2024

There is no "One Pixel Snap" button so this PR adds one.

P.S. I'm not sure if the button should be called "One-Pixel Snap" or "Pixel Snap".

Untitled

@Spartan322
Copy link
Member

This new option needs a different icon.

@SkogiB
Copy link
Contributor

SkogiB commented Oct 16, 2024

Such a good feature man, fantastic. Second Spartan's request for a unique icon for pixel snapping

@shoyguer
Copy link

@Spartan322 @valkyrienyanko
I created this .svg files, hope it helps.
SnapPixel

@valkyrienyanko
Copy link
Contributor Author

Thank you @shoyguer

image

@Spartan322
Copy link
Member

Would you be alright having this submitted upstream to Godot or do you want this to be a Redot only thing?

@valkyrienyanko
Copy link
Contributor Author

@Spartan322 You can submit this to Godot upstream if you want.

@Spartan322
Copy link
Member

Alright I'll cherry-pick it to upstream, see what they say about it.

@Spartan322
Copy link
Member

Spartan322 commented Oct 17, 2024

Actually I probably shouldn't throw this upstream without a proposal since its feature request but I can't just submit a proposal to Godot without a good case for its use which I don't myself have, so I'm not really able to submit this upstream, if someone who needs this would like to submit a proposal, that be great.

@SkogiB
Copy link
Contributor

SkogiB commented Oct 17, 2024

SVG static checker reeeeeeeeeeee

@SkogiB
Copy link
Contributor

SkogiB commented Oct 18, 2024

If you get pre-commit installed this should hopefully pass the static check for the .svg

@Majoramari
Copy link
Contributor

If you get pre-commit installed this should hopefully pass the static check for the .svg

@valkyrienyanko Hey use this command to help you with the svg checker

svgo --config=misc/utility/svgo.config.mjs <input.svg> -o output.svg

Make sure to install svgo

@Spartan322
Copy link
Member

Spartan322 commented Oct 21, 2024

It be better to just install pre-commit to your repo and just run it as it already handles that.

@valkyrienyanko
Copy link
Contributor Author

Alright I've ran pre-commit and it modified the svg. I've pushed new commit with these changes.

@Majoramari
Copy link
Contributor

Alright I've ran pre-commit and it modified the svg. I've pushed new commit with these changes.

Thanks if you could squash the commits to the first 1 only

@valkyrienyanko valkyrienyanko force-pushed the add-pixel-snap-to-tile-editor branch from bee2aa5 to e8e8a88 Compare October 21, 2024 19:36
@valkyrienyanko
Copy link
Contributor Author

Squashed

@Spartan322 Spartan322 added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Oct 23, 2024
@Spartan322 Spartan322 merged commit 3383574 into Redot-Engine:master Oct 23, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release enhancement topic:editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants