-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add One Pixel Snap Button to the Tile Data Editor #726
Add One Pixel Snap Button to the Tile Data Editor #726
Conversation
This new option needs a different icon. |
Such a good feature man, fantastic. Second Spartan's request for a unique icon for pixel snapping |
@Spartan322 @valkyrienyanko |
Thank you @shoyguer |
Would you be alright having this submitted upstream to Godot or do you want this to be a Redot only thing? |
@Spartan322 You can submit this to Godot upstream if you want. |
Alright I'll cherry-pick it to upstream, see what they say about it. |
Actually I probably shouldn't throw this upstream without a proposal since its feature request but I can't just submit a proposal to Godot without a good case for its use which I don't myself have, so I'm not really able to submit this upstream, if someone who needs this would like to submit a proposal, that be great. |
SVG static checker reeeeeeeeeeee |
If you get pre-commit installed this should hopefully pass the static check for the .svg |
@valkyrienyanko Hey use this command to help you with the svg checker svgo --config=misc/utility/svgo.config.mjs <input.svg> -o output.svg Make sure to install svgo |
It be better to just install pre-commit to your repo and just run it as it already handles that. |
Alright I've ran pre-commit and it modified the svg. I've pushed new commit with these changes. |
Thanks if you could squash the commits to the first 1 only |
bee2aa5
to
e8e8a88
Compare
Squashed |
There is no "One Pixel Snap" button so this PR adds one.
P.S. I'm not sure if the button should be called "One-Pixel Snap" or "Pixel Snap".