Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix Slack release message #1227

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Aug 14, 2023

What/Why/How?

Makes release message in Slack useful:

:bookmark: New @redocly/cli release 1.1.0

*Minor Changes*

•   Testing.

*Patch Changes*

•   Testing...

:bookmark: New @redocly/openapi-core release 1.1.0

*Patch Changes*

•   Testing...

Also, it attempts to fix failure on the performance check due to lack of permissions (when running from a fork) - added a check if the repository that triggered the event is the same as the base one.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@tatomyr tatomyr requested a review from a team as a code owner August 14, 2023 12:22
@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

⚠️ No Changeset found

Latest commit: 83904ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tatomyr tatomyr self-assigned this Aug 14, 2023
scripts/post-changeset.js Dismissed Show dismissed Hide dismissed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.259 ± 0.011 1.247 1.274 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.273 ± 0.043 1.228 1.346 1.01 ± 0.03

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.42% 3783/5016
🟡 Branches 66.33% 2098/3163
🟡 Functions 68.53% 636/928
🟡 Lines 75.57% 3533/4675

Test suite run success

622 tests passing in 91 suites.

Report generated by 🧪jest coverage report action from 83904ce

@tatomyr tatomyr merged commit 9fdf321 into main Aug 14, 2023
30 checks passed
@tatomyr tatomyr deleted the chore/fix-slack-release-message branch August 14, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants