Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed chunkSize addition to TS.INFO ( backwards compatible ) #78

Merged
merged 4 commits into from
Aug 28, 2020

Conversation

filipecosta90
Copy link
Collaborator

The following PR fixes the current CI failures due to the addition of chunkSize to TS.INFO

@filipecosta90 filipecosta90 added the bug Something isn't working label Aug 27, 2020
@filipecosta90 filipecosta90 changed the title Fixed chunckSize addition to TS.INFO ( backwards compatible ) Fixed chunkSize addition to TS.INFO ( backwards compatible ) Aug 27, 2020
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #78 into master will decrease coverage by 0.85%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   81.97%   81.12%   -0.86%     
==========================================
  Files           7        7              
  Lines         477      482       +5     
==========================================
  Hits          391      391              
- Misses         46       51       +5     
  Partials       40       40              
Impacted Files Coverage Δ
common.go 86.20% <ø> (ø)
reply_parser.go 65.85% <33.33%> (-2.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fdebc2...90ee0af. Read the comment docs.

Copy link
Contributor

@ashtul ashtul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@filipecosta90 filipecosta90 merged commit eafbc6b into master Aug 28, 2020
@filipecosta90 filipecosta90 deleted the chunck.size.fixes branch August 28, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants