Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove typing dependency. typing should be only used from python <3.5 #94

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Remove typing dependency. typing should be only used from python <3.5 #94

merged 1 commit into from
Mar 21, 2023

Conversation

danni-m
Copy link
Contributor

@danni-m danni-m commented Mar 21, 2023 •
edited
Loading

According to pypi typing is supported only for older python versions:

Python >=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, <3.5

Reference: https://pypi.org/project/typing

@danni-m danni-m requested a review from chayim March 21, 2023 07:57
@chayim
Copy link
Contributor

chayim commented Mar 21, 2023

Good catch - holdover from the old days.

@chayim chayim merged commit c7a709b into master Mar 21, 2023
@chayim chayim deleted the remove_typing_dep branch March 21, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chayim chayim chayim approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danni-m @chayim