Fix incorrect calculation of weighted average of elapsed time #209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I found that
timeval_factorial_average
function calculated incorrect the average of the elapsed time, so I fixed it.The original version calculates averages separately for seconds and microseconds.
This sometimes causes the average of X and X to be X-1 and the measured throughputs to be unstable.
I have even seen the total average time become negative.
This code below shows an example of the parameters that causes incorrect calculation.
Thank you.