Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable key placeholder to be combined with other data within the same command argument #154

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

filipecosta90
Copy link
Collaborator

Fixes #153
This PR adds the option to combine key placeholders with other characters within the same argument. This is important for RedisGraph and RediSearch for us to be able to mix for example node ids with other conditions, etc...
I've used this feature on RG 2.0 benchmark and forgot to open the PR to kick off this feature discussion.
Example of usage:

memtier_benchmark -c 10 -t 1 \
    --command="graph.query GRAPH1 \"MATCH (s:vertex)-[*6]->(t) WHERE id_in_graph(s)=__key__ RETURN count(t)\"" \
    --key-maximum=100000 --distinct-client-seed --command-key-pattern G --key-prefix=""

This PR includes two extra tests

protocol.cpp Outdated Show resolved Hide resolved
client.cpp Show resolved Hide resolved
client.cpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in complex arbitrary command
2 participants