Merge pull request #75 from RedHatSatellite/rel400

Release 4.0.0

.ansible-lint

@@ -6,3 +6,6 @@ enable_list:
   - only-builtins
 only_builtins_allow_collections:
   - redhat.satellite
+exclude_paths:
+  - changelogs/changelog.yml
+  - tests/

.github/workflows/codeql-analysis.yml

@@ -29,9 +29,9 @@ jobs:
       uses: actions/checkout@v4
 
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@v2
+      uses: github/codeql-action/init@v3
       with:
         languages: ${{ matrix.language }}
 
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v2
+      uses: github/codeql-action/analyze@v3

.github/workflows/docs.yml

@@ -23,7 +23,7 @@ jobs:
           git config user.email "${GITHUB_ACTOR}@bots.github.com"
           git fetch --no-tags --prune --depth=1 origin +refs/heads/*:refs/remotes/origin/*
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: "3.11"
       - name: Install dependencies

.github/workflows/main.yml

@@ -50,7 +50,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python }}
           cache: 'pip'
@@ -95,7 +95,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: "3.11"
           cache: 'pip'
@@ -122,7 +122,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: "3.11"
           cache: 'pip'
@@ -134,7 +134,7 @@ jobs:
       - name: Build docs
         run: make doc
       - name: Upload docs artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: docs-html
           path: docs/_build/html/
@@ -144,7 +144,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: "3.11"
           cache: 'pip'
@@ -159,7 +159,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: "3.11"
           cache: 'pip'
@@ -171,7 +171,7 @@ jobs:
       - name: Run lint
         run: make lint
       - name: Upload collection artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: collection
           path: redhat-satellite-*.tar.gz
@@ -181,7 +181,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: "3.11"
           cache: 'pip'

.github/workflows/release.yml

@@ -16,7 +16,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: "3.11"
       - name: Install Ansible

CHANGELOG.rst

@@ -6,6 +6,26 @@ redhat.satellite Release Notes
 
 This changelog describes changes after version 0.8.1.
 
+v4.0.0
+======
+
+Breaking Changes / Porting Guide
+--------------------------------
+
+- content_view_filter - stop managing rules from this module, ``content_view_filter_rule`` should be used for that
+- inventory plugin - do not default to ``http://localhost:3000`` as the Foreman URL, providing a URL is now mandatory
+
+Bugfixes
+--------
+
+- compute_profile, host - refer to VMware storage pods by name, not id (https://github.com/theforeman/foreman-ansible-modules/issues/1247)
+
+New Modules
+-----------
+
+- redhat.satellite.registration_command - Manage Registration Command
+- redhat.satellite.webhook - Manage Webhooks
+
 v3.15.0
 =======
 

changelogs/changelog.yaml

@@ -821,3 +821,24 @@ releases:
       name: hostgroup_info
       namespace: ''
     release_date: '2023-02-20'
+  4.0.0:
+    changes:
+      breaking_changes:
+      - content_view_filter - stop managing rules from this module, ``content_view_filter_rule``
+        should be used for that
+      - inventory plugin - do not default to ``http://localhost:3000`` as the Foreman
+        URL, providing a URL is now mandatory
+      bugfixes:
+      - compute_profile, host - refer to VMware storage pods by name, not id (https://github.com/theforeman/foreman-ansible-modules/issues/1247)
+    fragments:
+    - 1247-reference_storage_pod_name.yml
+    - content_view_filter-drop-rule-management.yml
+    - inventory-no-default-localhost.yml
+    modules:
+    - description: Manage Registration Command
+      name: registration_command
+      namespace: ''
+    - description: Manage Webhooks
+      name: webhook
+      namespace: ''
+    release_date: '2024-01-12'

galaxy.yml

@@ -26,6 +26,7 @@ authors:
   - "Evgeni Golov <[email protected]>"
   - "Ewoud Kohl van Wijngaarden <[email protected]>"
   - "Felix Fontein <[email protected]>"
+  - "Francesco Trentini <[email protected]>"
   - "Gerald Vogt <[email protected]>"
   - "Greg Swift <[email protected]>"
   - "Griffin Sullivan <[email protected]>"
@@ -34,6 +35,7 @@ authors:
   - "Jameer Pathan <[email protected]>"
   - "James Jeffers <[email protected]>"
   - "James Stuart <[email protected]>"
+  - "Jan Jansky <[email protected]>"
   - "Jeffrey van Pelt <[email protected]>"
   - "Jeremy Albinet <[email protected]>"
   - "Jeremy Lenz <[email protected]>"
@@ -47,6 +49,7 @@ authors:
   - "Lester Cheung <[email protected]>"
   - "Lester Claudio <[email protected]>"
   - "Lucas Bickel <[email protected]>"
+  - "Lukas Kallies <[email protected]>"
   - "Lukas Magauer <[email protected]>"
   - "Lukáš Zapletal <[email protected]>"
   - "Manisha Singhal <[email protected]>"
@@ -78,6 +81,7 @@ authors:
   - "Sean O'Keeffe <[email protected]>"
   - "Sorin Sbarnea <[email protected]>"
   - "Steffen Frömer <[email protected]>"
+  - "Steffen Scheib <[email protected]>"
   - "Stoned Elipot <[email protected]>"
   - "Sven Meeus <[email protected]>"
   - "TTherouanne <[email protected]>"
@@ -99,7 +103,7 @@ authors:
   - "russianguppie <[email protected]>"
   - "willtome <[email protected]>"
   - "yuqo2450 <[email protected]>"
-version: "3.15.0"
+version: "4.0.0"
 license:
   - "GPL-3.0-or-later"
 tags:

meta/runtime.yml

@@ -53,6 +53,7 @@ action_groups:
   - puppet_environment
   - puppetclasses_import
   - realm
+  - registration_command
   - repository
   - repository_info
   - repository_set
@@ -77,6 +78,7 @@ action_groups:
   - user
   - usergroup
   - wait_for_task
+  - webhook
 plugin_routing:
   modules:
     foreman_architecture:

plugins/inventory/foreman.py

@@ -32,7 +32,7 @@
       url:
         description:
           - URL of the Foreman server.
-        default: 'http://localhost:3000'
+        required: true
         env:
             - name: FOREMAN_SERVER
             - name: FOREMAN_SERVER_URL

plugins/modules/compute_profile.py

@@ -208,7 +208,7 @@ def main():
                         for volume in ca_module_params['vm_attrs']['volumes_attributes'].values():
                             if 'storage_pod' in volume:
                                 storage_pod = module.find_storage_pod(volume['storage_pod'], compute_resource, cluster)
-                                volume['storage_pod'] = storage_pod['id']
+                                volume['storage_pod'] = storage_pod['name']
                             if 'storage_domain' in volume:
                                 storage_domain = module.find_storage_domain(volume['storage_domain'], compute_resource, cluster)
                                 volume['storage_domain'] = storage_domain['id']