Create html based report for dry runs for cloud providers. #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M Sajid Mansoori <[email protected]>
msajidmansoori12
force-pushed
the
html-report-develop
branch
from
58ff6c0 to
e0975a9
Compare
msajidmansoori12
force-pushed
the
html-report-develop
branch
from
e0975a9 to
fbde185
Compare
jyejare
reviewed
Sep 27, 2024
cloudwash/utils.py
Outdated
| logger.info("Resources eligible for cleanup:") | ||
| for key, value in resource_data.items(): | ||
| if value and key != "provider": | ||
| logger.info( |
There was a problem hiding this comment.
This is repeating Deletable VMs with VMs (or any resource type), So its good to keep the old format of:
=========== DRY SUMMARY ============
VMs:
Deletable: ['test-bvhoduliam']
Stoppable: ['foremanqe-nightly2']
There was a problem hiding this comment.
Makes sense, refactored the code to print the same way.
msajidmansoori12
force-pushed
the
html-report-develop
branch
from
61c128b to
b988f63
Compare
msajidmansoori12
force-pushed
the
html-report-develop
branch
from
b988f63 to
b9af1d1
Compare
|
|
jyejare
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to create html based reports for dry runs for AWS, AZURE, GCP.
Sample report attached.
