Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Develop] Code Abstraction/Standardisation of Resource Types #116

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

jyejare
Copy link
Collaborator

@jyejare jyejare commented Nov 3, 2023

New changes to the Code Base!

  • A grandparent AbstractClass 'ResourceCleanup' for all resource types cleanup
  • A Resource Type Abstract class that every resource provider has to inherit
    • This PR includes VMsCleanup abstract class
    • That abstract class to be inherited by individual resource provider Resource Type class.
      • E.g in this PR here AWS 'CleanVMs'
  • The logging and dry data setting is now native to resource provider Resource Type class directly.

@jyejare jyejare changed the title Abstraction of Resources for cleanup [Develop] Abstraction of Resources for cleanup Nov 3, 2023
@jyejare jyejare force-pushed the jyejare-abstract-refactor branch from d483be7 to f649bad Compare November 3, 2023 15:42

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
More:
AWS Cleanup for VMs changed with new structure
Pre Drydata improvements before major refactor
@jyejare jyejare force-pushed the jyejare-abstract-refactor branch from f649bad to c14f163 Compare November 3, 2023 15:44
@jyejare jyejare changed the title [Develop] Abstraction of Resources for cleanup [Develop] Code Abstraction/Standardisation of Resource Types Nov 3, 2023
@jyejare jyejare merged commit 5f91930 into RedHatQE:develop Nov 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant