Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RHINENG-9035): bulk select all icon fixed #1182

Merged
merged 1 commit into from
May 13, 2024
Merged

fix(RHINENG-9035): bulk select all icon fixed #1182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"@patternfly/react-core": "^5.2.0",
"@patternfly/react-icons": "^5.2.0",
"@patternfly/react-table": "^5.2.0",
"@redhat-cloud-services/frontend-components": "^4.2.4",
"@redhat-cloud-services/frontend-components": "^4.2.8",
"@redhat-cloud-services/frontend-components-notifications": "^4.1.0",
"@redhat-cloud-services/frontend-components-remediations": "^3.2.11",
"@redhat-cloud-services/frontend-components-translations": "^3.2.7",
Expand Down
170 changes: 120 additions & 50 deletions src/PresentationalComponents/Header/__snapshots__/Header.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ exports[`Header component should render with 1 breadcrumb item and last is activ
<DocumentFragment>
<section
class="pf-v5-l-page-header pf-v5-c-page-header pf-v5-l-page__main-section pf-v5-c-page__main-section pf-m-light"
data-ouia-component-id="OUIA-Generated-RHI/Header-true-7"
data-ouia-component-type="undefined-page-header"
data-ouia-safe="true"
widget-type="InsightsPageHeader"
>
<nav
Expand Down Expand Up @@ -37,13 +39,21 @@ exports[`Header component should render with 1 breadcrumb item and last is activ
<div
class="pf-v5-l-split__item"
>
<h1
class="pf-v5-c-title pf-m-2xl"
data-ouia-component-id="OUIA-Generated-Title-4"
data-ouia-component-type="PF5/Title"
data-ouia-safe="true"
widget-type="InsightsPageHeaderTitle"
/>
<div
class="pf-v5-l-flex pf-m-justify-content-space-between"
>
<div
class=""
>
<h1
class="pf-v5-c-title pf-m-2xl"
data-ouia-component-id="OUIA-Generated-RHI/Header-true-8"
data-ouia-component-type="RHI/Header"
data-ouia-safe="true"
widget-type="InsightsPageHeaderTitle"
/>
</div>
</div>
</div>
<div
class="pf-v5-l-split__item pf-m-fill"
Expand All @@ -60,7 +70,9 @@ exports[`Header component should render with 2 breadcrumb items and last is acti
<DocumentFragment>
<section
class="pf-v5-l-page-header pf-v5-c-page-header pf-v5-l-page__main-section pf-v5-c-page__main-section pf-m-light"
data-ouia-component-id="OUIA-Generated-RHI/Header-true-11"
data-ouia-component-type="undefined-page-header"
data-ouia-safe="true"
widget-type="InsightsPageHeader"
>
<nav
Expand Down Expand Up @@ -121,13 +133,21 @@ exports[`Header component should render with 2 breadcrumb items and last is acti
<div
class="pf-v5-l-split__item"
>
<h1
class="pf-v5-c-title pf-m-2xl"
data-ouia-component-id="OUIA-Generated-Title-6"
data-ouia-component-type="PF5/Title"
data-ouia-safe="true"
widget-type="InsightsPageHeaderTitle"
/>
<div
class="pf-v5-l-flex pf-m-justify-content-space-between"
>
<div
class=""
>
<h1
class="pf-v5-c-title pf-m-2xl"
data-ouia-component-id="OUIA-Generated-RHI/Header-true-12"
data-ouia-component-type="RHI/Header"
data-ouia-safe="true"
widget-type="InsightsPageHeaderTitle"
/>
</div>
</div>
</div>
<div
class="pf-v5-l-split__item pf-m-fill"
Expand All @@ -144,7 +164,9 @@ exports[`Header component should render with 3 breadcrumb items and last is acti
<DocumentFragment>
<section
class="pf-v5-l-page-header pf-v5-c-page-header pf-v5-l-page__main-section pf-v5-c-page__main-section pf-m-light"
data-ouia-component-id="OUIA-Generated-RHI/Header-true-13"
data-ouia-component-type="undefined-page-header"
data-ouia-safe="true"
widget-type="InsightsPageHeader"
>
<nav
Expand Down Expand Up @@ -233,13 +255,21 @@ exports[`Header component should render with 3 breadcrumb items and last is acti
<div
class="pf-v5-l-split__item"
>
<h1
class="pf-v5-c-title pf-m-2xl"
data-ouia-component-id="OUIA-Generated-Title-7"
data-ouia-component-type="PF5/Title"
data-ouia-safe="true"
widget-type="InsightsPageHeaderTitle"
/>
<div
class="pf-v5-l-flex pf-m-justify-content-space-between"
>
<div
class=""
>
<h1
class="pf-v5-c-title pf-m-2xl"
data-ouia-component-id="OUIA-Generated-RHI/Header-true-14"
data-ouia-component-type="RHI/Header"
data-ouia-safe="true"
widget-type="InsightsPageHeaderTitle"
/>
</div>
</div>
</div>
<div
class="pf-v5-l-split__item pf-m-fill"
Expand All @@ -256,7 +286,9 @@ exports[`Header component should render with empty breadcrumb 1`] = `
<DocumentFragment>
<section
class="pf-v5-l-page-header pf-v5-c-page-header pf-v5-l-page__main-section pf-v5-c-page__main-section pf-m-light"
data-ouia-component-id="OUIA-Generated-RHI/Header-true-5"
data-ouia-component-type="undefined-page-header"
data-ouia-safe="true"
widget-type="InsightsPageHeader"
>
<nav
Expand All @@ -277,13 +309,21 @@ exports[`Header component should render with empty breadcrumb 1`] = `
<div
class="pf-v5-l-split__item"
>
<h1
class="pf-v5-c-title pf-m-2xl"
data-ouia-component-id="OUIA-Generated-Title-3"
data-ouia-component-type="PF5/Title"
data-ouia-safe="true"
widget-type="InsightsPageHeaderTitle"
/>
<div
class="pf-v5-l-flex pf-m-justify-content-space-between"
>
<div
class=""
>
<h1
class="pf-v5-c-title pf-m-2xl"
data-ouia-component-id="OUIA-Generated-RHI/Header-true-6"
data-ouia-component-type="RHI/Header"
data-ouia-safe="true"
widget-type="InsightsPageHeaderTitle"
/>
</div>
</div>
</div>
<div
class="pf-v5-l-split__item pf-m-fill"
Expand All @@ -300,7 +340,9 @@ exports[`Header component should render with header Hello world 1`] = `
<DocumentFragment>
<section
class="pf-v5-l-page-header pf-v5-c-page-header pf-v5-l-page__main-section pf-v5-c-page__main-section pf-m-light"
data-ouia-component-id="OUIA-Generated-RHI/Header-true-3"
data-ouia-component-type="undefined-page-header"
data-ouia-safe="true"
widget-type="InsightsPageHeader"
>
<div
Expand All @@ -309,15 +351,23 @@ exports[`Header component should render with header Hello world 1`] = `
<div
class="pf-v5-l-split__item"
>
<h1
class="pf-v5-c-title pf-m-2xl"
data-ouia-component-id="OUIA-Generated-Title-2"
data-ouia-component-type="PF5/Title"
data-ouia-safe="true"
widget-type="InsightsPageHeaderTitle"
<div
class="pf-v5-l-flex pf-m-justify-content-space-between"
>
Hello world
</h1>
<div
class=""
>
<h1
class="pf-v5-c-title pf-m-2xl"
data-ouia-component-id="OUIA-Generated-RHI/Header-true-4"
data-ouia-component-type="RHI/Header"
data-ouia-safe="true"
widget-type="InsightsPageHeaderTitle"
>
Hello world
</h1>
</div>
</div>
</div>
<div
class="pf-v5-l-split__item pf-m-fill"
Expand All @@ -334,7 +384,9 @@ exports[`Header component should render with header as empty string 1`] = `
<DocumentFragment>
<section
class="pf-v5-l-page-header pf-v5-c-page-header pf-v5-l-page__main-section pf-v5-c-page__main-section pf-m-light"
data-ouia-component-id="OUIA-Generated-RHI/Header-true-1"
data-ouia-component-type="undefined-page-header"
data-ouia-safe="true"
widget-type="InsightsPageHeader"
>
<div
Expand All @@ -343,13 +395,21 @@ exports[`Header component should render with header as empty string 1`] = `
<div
class="pf-v5-l-split__item"
>
<h1
class="pf-v5-c-title pf-m-2xl"
data-ouia-component-id="OUIA-Generated-Title-1"
data-ouia-component-type="PF5/Title"
data-ouia-safe="true"
widget-type="InsightsPageHeaderTitle"
/>
<div
class="pf-v5-l-flex pf-m-justify-content-space-between"
>
<div
class=""
>
<h1
class="pf-v5-c-title pf-m-2xl"
data-ouia-component-id="OUIA-Generated-RHI/Header-true-2"
data-ouia-component-type="RHI/Header"
data-ouia-safe="true"
widget-type="InsightsPageHeaderTitle"
/>
</div>
</div>
</div>
<div
class="pf-v5-l-split__item pf-m-fill"
Expand All @@ -366,7 +426,9 @@ exports[`Header component should render without to attribute 1`] = `
<DocumentFragment>
<section
class="pf-v5-l-page-header pf-v5-c-page-header pf-v5-l-page__main-section pf-v5-c-page__main-section pf-m-light"
data-ouia-component-id="OUIA-Generated-RHI/Header-true-9"
data-ouia-component-type="undefined-page-header"
data-ouia-safe="true"
widget-type="InsightsPageHeader"
>
<nav
Expand All @@ -393,13 +455,21 @@ exports[`Header component should render without to attribute 1`] = `
<div
class="pf-v5-l-split__item"
>
<h1
class="pf-v5-c-title pf-m-2xl"
data-ouia-component-id="OUIA-Generated-Title-5"
data-ouia-component-type="PF5/Title"
data-ouia-safe="true"
widget-type="InsightsPageHeaderTitle"
/>
<div
class="pf-v5-l-flex pf-m-justify-content-space-between"
>
<div
class=""
>
<h1
class="pf-v5-c-title pf-m-2xl"
data-ouia-component-id="OUIA-Generated-RHI/Header-true-10"
data-ouia-component-type="RHI/Header"
data-ouia-safe="true"
widget-type="InsightsPageHeaderTitle"
/>
</div>
</div>
</div>
<div
class="pf-v5-l-split__item pf-m-fill"
Expand Down
24 changes: 17 additions & 7 deletions src/SmartComponents/AdvisoryDetail/__snapshots__/AdvisoryDetail.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ exports[`AdvisoryDetail.js Should match the snapshots 1`] = `
<DocumentFragment>
<section
class="pf-v5-l-page-header pf-v5-c-page-header pf-v5-l-page__main-section pf-v5-c-page__main-section pf-m-light"
data-ouia-component-id="OUIA-Generated-RHI/Header-true-1"
data-ouia-component-type="advisory-details-page-header"
data-ouia-safe="true"
widget-type="InsightsPageHeader"
>
<nav
Expand Down Expand Up @@ -58,13 +60,21 @@ exports[`AdvisoryDetail.js Should match the snapshots 1`] = `
<div
class="pf-v5-l-split__item"
>
<h1
class="pf-v5-c-title pf-m-2xl"
data-ouia-component-id="OUIA-Generated-Title-1"
data-ouia-component-type="PF5/Title"
data-ouia-safe="true"
widget-type="InsightsPageHeaderTitle"
/>
<div
class="pf-v5-l-flex pf-m-justify-content-space-between"
>
<div
class=""
>
<h1
class="pf-v5-c-title pf-m-2xl"
data-ouia-component-id="OUIA-Generated-RHI/Header-true-2"
data-ouia-component-type="RHI/Header"
data-ouia-safe="true"
widget-type="InsightsPageHeaderTitle"
/>
</div>
</div>
</div>
<div
class="pf-v5-l-split__item pf-m-fill"
Expand Down
1 change: 0 additions & 1 deletion src/SmartComponents/AdvisorySystems/AdvisorySystemsTable.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,6 @@ describe('AdvisorySystemsTable.js', () => {
],
onSelect: expect.any(Function),
toggleProps: {
children: ' 1 selected',
'aria-label': 'Select',
'data-ouia-component-type': 'bulk-select-toggle-button'
}
Expand Down
1 change: 0 additions & 1 deletion src/SmartComponents/Systems/SystemTable.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,6 @@ describe('SystemsTable', () => {
],
onSelect: expect.any(Function),
toggleProps: {
children: ' 1 selected',
'aria-label': 'Select',
'data-ouia-component-type': 'bulk-select-toggle-button'
}
Expand Down
Loading