fix: double icons in display name column on package systems table (#1183

) * fix: double icons in display name column on package systems table * chore: remove tags column defs from package systems table
RedHatInsights · May 22, 2024 · 7f7bc89 · 7f7bc89
1 parent bd177e8
commit 7f7bc89
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 16 deletions.
diff --git a/src/SmartComponents/Systems/SystemListAssets.test.js b/src/SmartComponents/Systems/SystemListAssets.test.js
@@ -23,7 +23,7 @@ describe('SystemListAssets.js', () => {
     });
 
     it('Should call createUpgradableColumn on Status renderFunc with correct params', () => {
-        packageSystemsColumns[6].renderFunc('testValue');
+        packageSystemsColumns[4].renderFunc('testValue');
         expect(createUpgradableColumn).toHaveBeenCalledWith('testValue');
     });
 

diff --git a/src/SmartComponents/Systems/SystemsListAssets.js b/src/SmartComponents/Systems/SystemsListAssets.js
@@ -95,19 +95,6 @@ export const advisorySystemsColumns = () => [
 ];
 
 export const packageSystemsColumns = [
-    {
-        key: 'display_name',
-        title: 'Name',
-        composed: ['facts.os_release', 'display_name'],
-        props: {
-            width: 40
-        }
-    },
-    {
-        key: 'tags',
-        title: 'Tags',
-        props: { width: 10, isStatic: true }
-    },
     {
         key: 'os',
         title: 'OS',

diff --git a/src/Utilities/SystemHelpers.test.js b/src/Utilities/SystemHelpers.test.js
@@ -26,10 +26,10 @@ describe('createSystemsSortBy,', () => {
 
     it('should translate updated parameter while having last upload', () => {
         expect(createSystemsSortBy('updated', 'ASC', true)).toEqual(
-            'display_name'
+            'os'
         );
         expect(createSystemsSortBy('updated', 'DESC', true)).toEqual(
-            '-display_name'
+            '-os'
         );
     });
 });