Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with recipients query #459

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

josejulio
Copy link
Member

Look like the AuthRequestfilter does not process the @PostProcess, maybe related to this one: quarkusio/quarkus#5752

Maybe it works on quarkus 2.0+? Anyway, meanwhile I'm going to use the constructor to load the required params.

@josejulio josejulio requested a review from bennetelli August 5, 2021 18:56
Copy link
Contributor

@bennetelli bennetelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation of javax.ws.rs.client.ClientRequestFilter says: "An extension interface implemented by client request filters. Filters implementing this interface MUST be annotated with @Provider to be discovered by the runtime. This type of filters is supported only as part of the Client API."

Do we need to do this, too? Does Quarkus do this or is this just not necessary anymore?

@josejulio
Copy link
Member Author

The documentation of javax.ws.rs.client.ClientRequestFilter says: "An extension interface implemented by client request filters. Filters implementing this interface MUST be annotated with @Provider to be discovered by the runtime. This type of filters is supported only as part of the Client API."

Maybe that is what I was missing :D

@bennetelli
Copy link
Contributor

The documentation of javax.ws.rs.client.ClientRequestFilter says: "An extension interface implemented by client request filters. Filters implementing this interface MUST be annotated with @Provider to be discovered by the runtime. This type of filters is supported only as part of the Client API."

Maybe that is what I was missing :D

Could be :D

@bennetelli
Copy link
Contributor

I mean, if you tested it and it's working, than I can also approve it. I don't prefer that one way over the other.

@josejulio
Copy link
Member Author

I mean, if you tested it and it's working, than I can also approve it. I don't prefer that one way over the other.

So I was looking it at more detail and followed the PR i mention on the first comment. I couldn't see what's wrong, but it works (using the same quarkus version we use) on the sample.

Anyhow regarding the Provider it appears that you have to add it if you want to have a global filter, if not, adding the RegisterProvider annotation on the specific client works.

So yes, this is working as we need.

@bennetelli bennetelli self-requested a review August 6, 2021 15:27
@josejulio
Copy link
Member Author

+1
Lets merge it quickly before @gwenneg sees ;)

@josejulio josejulio merged commit c0f814b into RedHatInsights:master Aug 6, 2021
@josejulio josejulio deleted the fix-recipients-query branch August 6, 2021 15:29
@bennetelli
Copy link
Contributor

Psssssscht! Not that loud! :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants