-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue with recipients query #459
Fixes issue with recipients query #459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation of javax.ws.rs.client.ClientRequestFilter says: "An extension interface implemented by client request filters. Filters implementing this interface MUST be annotated with @Provider to be discovered by the runtime. This type of filters is supported only as part of the Client API."
Do we need to do this, too? Does Quarkus do this or is this just not necessary anymore?
Maybe that is what I was missing :D |
Could be :D |
I mean, if you tested it and it's working, than I can also approve it. I don't prefer that one way over the other. |
So I was looking it at more detail and followed the PR i mention on the first comment. I couldn't see what's wrong, but it works (using the same quarkus version we use) on the sample. Anyhow regarding the So yes, this is working as we need. |
+1 |
Psssssscht! Not that loud! :P |
Look like the
AuthRequestfilter
does not process the@PostProcess
, maybe related to this one: quarkusio/quarkus#5752Maybe it works on quarkus 2.0+? Anyway, meanwhile I'm going to use the constructor to load the required params.