Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RHINENG-9687): create system type filter #2190

Merged
merged 5 commits into from
May 3, 2024

Conversation

mkholjuraev
Copy link
Contributor

Impements https://issues.redhat.com/browse/RHINENG-9687.

The new filter should only be visible to customers that have bootc images and when the feature is enabled. The filter should comply with the design in this mockup: https://www.figma.com/file/izOiimeI3i1a44dKEaFsUf/Systems-in-Bifrost?type=design&node-id=1016-41257&mode=design&t=ZYd83sqYOyalba6a-4

To test:

  1. Run the PR
  2. Navigate to the landing page in the Inventory page
  3. Observe that now there is a new 'System type' filter among others in the filters dropdown
  4. Try filtering the table with package mode, observe that the request is made with filter[system_profile][bootc_status][booted][image_digest]=nil
  5. Try filtering the table with image mode, and observe that the request is made with filter[system_profile][bootc_status][booted][image_digest]=not_nil
  6. In general, play with it

@mkholjuraev mkholjuraev requested a review from a team as a code owner May 3, 2024 10:09
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 57.25%. Comparing base (7b112ea) to head (4c62cdf).
Report is 2 commits behind head on master.

Files Patch % Lines
src/components/filters/useSystemTypeFilter.js 66.66% 7 Missing ⚠️
...rc/components/InventoryTable/EntityTableToolbar.js 80.00% 3 Missing ⚠️
src/api/api.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2190      +/-   ##
==========================================
+ Coverage   57.06%   57.25%   +0.18%     
==========================================
  Files         207      208       +1     
  Lines        6400     6447      +47     
  Branches     1785     1809      +24     
==========================================
+ Hits         3652     3691      +39     
- Misses       2748     2756       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@computercamplove
Copy link
Contributor

computercamplove commented May 3, 2024

@mkholjuraev

  1. i still see "System update method" filter
    image

  2. when i apply "System type" filter, then switch to Immutable tab/Images table view and switch back to conventional tab - > filter is removed

@computercamplove
Copy link
Contributor

Filter works as expected:

  1. account without image mode systems doesn't see this filter
  2. able to filter together with other filters
  3. able to sort systems without resetting system type filter

minor issues:

  1. filter is not saved in URL
  2. according to acceptance criteria "System update method" should be removed

@computercamplove
Copy link
Contributor

/retest

@mkholjuraev
Copy link
Contributor Author

Comments will be addressed in the next PR.

@mkholjuraev mkholjuraev merged commit a14c486 into RedHatInsights:master May 3, 2024
0 of 2 checks passed
@gkarat
Copy link
Contributor

gkarat commented May 3, 2024

🎉 This PR is included in version 1.74.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gkarat gkarat added the released label May 3, 2024
adonispuente added a commit that referenced this pull request May 7, 2024
mkholjuraev added a commit to mkholjuraev/insights-inventory-frontend that referenced this pull request May 31, 2024
mkholjuraev added a commit to mkholjuraev/insights-inventory-frontend that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants