-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RHINENG-9687): create system type filter #2190
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2190 +/- ##
==========================================
+ Coverage 57.06% 57.25% +0.18%
==========================================
Files 207 208 +1
Lines 6400 6447 +47
Branches 1785 1809 +24
==========================================
+ Hits 3652 3691 +39
- Misses 2748 2756 +8 ☔ View full report in Codecov by Sentry. |
Filter works as expected:
minor issues:
|
/retest |
Comments will be addressed in the next PR. |
🎉 This PR is included in version 1.74.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This reverts commit a14c486.
…Insights#2190)"" This reverts commit 4c9d70f.
…Insights#2190)"" This reverts commit 4c9d70f.
Impements https://issues.redhat.com/browse/RHINENG-9687.
The new filter should only be visible to customers that have bootc images and when the feature is enabled. The filter should comply with the design in this mockup: https://www.figma.com/file/izOiimeI3i1a44dKEaFsUf/Systems-in-Bifrost?type=design&node-id=1016-41257&mode=design&t=ZYd83sqYOyalba6a-4
To test:
filter[system_profile][bootc_status][booted][image_digest]=nil
filter[system_profile][bootc_status][booted][image_digest]=not_nil